[patch] custom_extraperms.cgi-use-uri_encode-on-usernames.patch

0001-custom_extraperms.cgi-use-uri_encode-on-usernames.patch (text/plain), 1.59 KB, created by Adam Feldman on 2016-09-06 01:15:25 UTC

From c5161462ec5c011e6af81a356f2d63da74f332fa Mon Sep 17 00:00:00 2001
From: NP-Hardass <[e-mail]>
Date: Mon, 5 Sep 2016 21:00:47 -0400
Subject: [PATCH] custom_extraperms.cgi: use uri_encode on usernames

Encodes usernames so that they are passed properly in the query URI

Gentoo-Bug: #582706
---
 custom_extraperms.cgi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/custom_extraperms.cgi b/custom_extraperms.cgi
index 01ffcbe..ceda007 100755
--- a/custom_extraperms.cgi
+++ b/custom_extraperms.cgi
@@ -3,6 +3,8 @@ use strict;
 
 use lib qw(. lib);
 
+use URI::Escape;
+
 use Bugzilla;
 use Bugzilla::Constants;
 use Bugzilla::Error;
@@ -59,7 +61,7 @@ $users = $dbh->selectall_arrayref(
 
 printf "<h3>Arch Testers that are not \@gentoo.org</h3>\n";
 foreach my $row (@$users) {
-	printf "<a href='%scustom_userhistory.cgi?matchstr=%s'>%s</a><br />\n", correct_urlbase(), $row->{'login_name'}, $row->{'login_name'};
+	printf "<a href='%scustom_userhistory.cgi?matchstr=%s'>%s</a><br />\n", correct_urlbase(), uri_escape($row->{'login_name'}), $row->{'login_name'};
 }
 
 $users = $dbh->selectall_arrayref(
@@ -69,5 +71,5 @@ $users = $dbh->selectall_arrayref(
 );
 printf "<h3>Users with Other Groups</h3>\n";
 foreach my $row (@$users) {
-	printf "<a href='%scustom_userhistory.cgi?matchstr=%s'>%s</a>: %s<br />\n", correct_urlbase(), $row->{'login_name'}, $row->{'login_name'}, $row->{'group_name'};
+	printf "<a href='%scustom_userhistory.cgi?matchstr=%s'>%s</a>: %s<br />\n", correct_urlbase(), uri_escape($row->{'login_name'}), $row->{'login_name'}, $row->{'group_name'};
 }
-- 
2.7.3