From c5161462ec5c011e6af81a356f2d63da74f332fa Mon Sep 17 00:00:00 2001 From: NP-Hardass Date: Mon, 5 Sep 2016 21:00:47 -0400 Subject: [PATCH] custom_extraperms.cgi: use uri_encode on usernames Encodes usernames so that they are passed properly in the query URI Gentoo-Bug: #582706 --- custom_extraperms.cgi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/custom_extraperms.cgi b/custom_extraperms.cgi index 01ffcbe..ceda007 100755 --- a/custom_extraperms.cgi +++ b/custom_extraperms.cgi @@ -3,6 +3,8 @@ use strict; use lib qw(. lib); +use URI::Escape; + use Bugzilla; use Bugzilla::Constants; use Bugzilla::Error; @@ -59,7 +61,7 @@ $users = $dbh->selectall_arrayref( printf "

Arch Testers that are not \@gentoo.org

\n"; foreach my $row (@$users) { - printf "%s
\n", correct_urlbase(), $row->{'login_name'}, $row->{'login_name'}; + printf "%s
\n", correct_urlbase(), uri_escape($row->{'login_name'}), $row->{'login_name'}; } $users = $dbh->selectall_arrayref( @@ -69,5 +71,5 @@ $users = $dbh->selectall_arrayref( ); printf "

Users with Other Groups

\n"; foreach my $row (@$users) { - printf "%s: %s
\n", correct_urlbase(), $row->{'login_name'}, $row->{'login_name'}, $row->{'group_name'}; + printf "%s: %s
\n", correct_urlbase(), uri_escape($row->{'login_name'}), $row->{'login_name'}, $row->{'group_name'}; } -- 2.7.3