Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 306307 Details for
Bug 409281
media-sound/easytag-2.1.7-r1: compilation fails with =media-libs/libmp4v2-1.9.1_p479
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Not backwards compatible and unfinished patch
easytag-2.1.7-libmp4v2_r479_compat.patch (text/plain), 2.29 KB, created by
Samuli Suominen (RETIRED)
on 2012-03-22 12:24:36 UTC
(
hide
)
Description:
Not backwards compatible and unfinished patch
Filename:
MIME Type:
Creator:
Samuli Suominen (RETIRED)
Created:
2012-03-22 12:24:36 UTC
Size:
2.29 KB
patch
obsolete
>diff -ur easytag-2.1.7.orig/src/mp4_header.c easytag-2.1.7/src/mp4_header.c >--- easytag-2.1.7.orig/src/mp4_header.c 2011-07-04 03:59:21.000000000 +0300 >+++ easytag-2.1.7/src/mp4_header.c 2012-03-22 14:16:24.446819057 +0200 >@@ -204,7 +204,7 @@ > /* Get size of file */ > ETFileInfo->size = Get_File_Size(filename); > >- if ((file = MP4Read(filename, 0)) == MP4_INVALID_FILE_HANDLE ) >+ if ((file = MP4Read(filename)) == MP4_INVALID_FILE_HANDLE ) > { > gchar *filename_utf8 = filename_to_display(filename); > //g_print(_("ERROR while opening file: '%s' (%s)."),filename_utf8,g_strerror(errno)); >@@ -218,7 +218,7 @@ > { > gchar *filename_utf8 = filename_to_display(filename); > Log_Print(LOG_ERROR,_("ERROR while opening file: '%s' (%s)."),filename_utf8,("Contains no audio track")); >- MP4Close(file); >+ MP4Close(file, 0); > g_free(filename_utf8); > return FALSE; > } >@@ -243,7 +243,7 @@ > ETFileInfo->mode = MP4GetTrackAudioChannels(file, trackId); > ETFileInfo->duration = MP4ConvertFromTrackDuration(file, trackId, MP4GetTrackDuration(file, trackId), MP4_SECS_TIME_SCALE); > >- MP4Close(file); >+ MP4Close(file, 0); > return TRUE; > } > >diff -ur easytag-2.1.7.orig/src/mp4_tag.c easytag-2.1.7/src/mp4_tag.c >--- easytag-2.1.7.orig/src/mp4_tag.c 2011-07-04 03:59:21.000000000 +0300 >+++ easytag-2.1.7/src/mp4_tag.c 2012-03-22 14:19:17.466805201 +0200 >@@ -102,7 +102,7 @@ > fclose(file); // We close it cause mp4 opens/closes file itself > > /* Get data from tag */ >- mp4file = MP4Read(filename, 0); >+ mp4file = MP4Read(filename); > if (mp4file == MP4_INVALID_FILE_HANDLE) > { > gchar *filename_utf8 = filename_to_display(filename); >@@ -213,7 +213,7 @@ > > > /* Free allocated data */ >- MP4Close(mp4file); >+ MP4Close(mp4file, 0); > > return TRUE; > } >@@ -252,7 +252,7 @@ > fclose(file); > > /* Open file for writing */ >- mp4file = MP4Modify(filename,0,0); >+ mp4file = MP4Modify(filename, 0); > if (mp4file == MP4_INVALID_FILE_HANDLE) > { > Log_Print(LOG_ERROR,_("ERROR while opening file: '%s' (%s)."),filename_utf8,_("MP4 format invalid")); >@@ -434,8 +434,7 @@ > } > } > >- >- MP4Close(mp4file); >+ MP4Close(mp4file, 0); > > if (error) return FALSE; > else return TRUE;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 409281
:
306269
|
306307
|
306917