Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 254311 Details for
Bug 345409
media-gfx/f-spot 0.8.0 taglib fails with mono 2.8
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch from https://bugzilla.gnome.org/show_bug.cgi?id=629222
f-spot-0.8.0-TagLib.patch (text/plain), 1.27 KB, created by
Damien Thébault
on 2010-11-14 14:49:18 UTC
(
hide
)
Description:
Patch from https://bugzilla.gnome.org/show_bug.cgi?id=629222
Filename:
MIME Type:
Creator:
Damien Thébault
Created:
2010-11-14 14:49:18 UTC
Size:
1.27 KB
patch
obsolete
>From: Marek Habersack <grendel@twistedcode.net> >Date: Wed, 15 Sep 2010 23:18:08 +0200 >Subject: [PATCH] All fields of a struct must be initialized before the constructor returns > >--- > lib/TagLib/TagLib/src/TagLib/IFD/Entries/Rational.cs | 6 ++++-- > lib/TagLib/TagLib/src/TagLib/IFD/Entries/SRational.cs | 6 ++++-- > 2 files changed, 8 insertions(+), 4 deletions(-) > >--- a/lib/TagLib/TagLib/src/TagLib/IFD/Entries/Rational.cs >+++ b/lib/TagLib/TagLib/src/TagLib/IFD/Entries/Rational.cs >@@ -62,8 +62,10 @@ namespace TagLib.IFD.Entries > /// </param> > public Rational (uint numerator, uint denominator) > { >- Numerator = numerator; >- Denominator = denominator; >+ if (denominator == 0) >+ throw new ArgumentException ("denominator"); >+ this.numerator = numerator; >+ this.denominator = denominator; > } > > #endregion >--- a/lib/TagLib/TagLib/src/TagLib/IFD/Entries/SRational.cs >+++ b/lib/TagLib/TagLib/src/TagLib/IFD/Entries/SRational.cs >@@ -62,8 +62,10 @@ namespace TagLib.IFD.Entries > /// </param> > public SRational (int numerator, int denominator) > { >- Numerator = numerator; >- Denominator = denominator; >+ if (denominator == 0) >+ throw new ArgumentException ("denominator"); >+ this.numerator = numerator; >+ this.denominator = denominator; > } > > #endregion
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 345409
:
254305
|
254307
| 254311 |
254313
|
254315