From: Marek Habersack Date: Wed, 15 Sep 2010 23:18:08 +0200 Subject: [PATCH] All fields of a struct must be initialized before the constructor returns --- lib/TagLib/TagLib/src/TagLib/IFD/Entries/Rational.cs | 6 ++++-- lib/TagLib/TagLib/src/TagLib/IFD/Entries/SRational.cs | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) --- a/lib/TagLib/TagLib/src/TagLib/IFD/Entries/Rational.cs +++ b/lib/TagLib/TagLib/src/TagLib/IFD/Entries/Rational.cs @@ -62,8 +62,10 @@ namespace TagLib.IFD.Entries /// public Rational (uint numerator, uint denominator) { - Numerator = numerator; - Denominator = denominator; + if (denominator == 0) + throw new ArgumentException ("denominator"); + this.numerator = numerator; + this.denominator = denominator; } #endregion --- a/lib/TagLib/TagLib/src/TagLib/IFD/Entries/SRational.cs +++ b/lib/TagLib/TagLib/src/TagLib/IFD/Entries/SRational.cs @@ -62,8 +62,10 @@ namespace TagLib.IFD.Entries /// public SRational (int numerator, int denominator) { - Numerator = numerator; - Denominator = denominator; + if (denominator == 0) + throw new ArgumentException ("denominator"); + this.numerator = numerator; + this.denominator = denominator; } #endregion