Bug 99861 – xsnap 1.4.3 ignores -hide option

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sérgio Luís 2005-07-21 18:14:11 UTC]

xsnap can be run with the -hide option, but when your run it with does option
xsnap thinks its invalid and shows you the usage.

The problem is xsnap thinks -hide is equal to -h because it matches -h with
strncmp(argv[i], "-h", 2);

Here's a small patch.

Reproducible: Always
Steps to Reproduce:
1.xsnap -hide

Actual Results:  
usage message appears

Expected Results:  
it should run properly, not saying i gave the wrong arguments.

[Comment 1 Sérgio Luís 2005-07-21 18:15:29 UTC]

Created attachment 64021 [details, diff]
Small patch to correct the bug.

[Comment 2 Sérgio Luís 2005-07-21 19:44:36 UTC]

There's another bug that must be corrected after this one.

$ xsnap -hide

xsnap:
Error code BadWindow (invalid Window parameter)

What happens is that with -hide option the window is not created, and in the
code theres a missing if (!display_in_window).

Here's a patch.
It contains the correction for this bug an the other one...

[Comment 3 Sérgio Luís 2005-07-21 19:47:44 UTC]

Created attachment 64028 [details, diff]
Patch that contains the two fixes.

[Comment 4 Jonathan Smith (RETIRED) 2005-07-25 15:15:11 UTC]

after accidentally committing using cvs instead of repoman, i fixed it all and
emailed upstream