Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 99572 - inclusion keyword description ambiguous
Summary: inclusion keyword description ambiguous
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Bugzilla (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Jeffrey Forman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-19 13:21 UTC by Thomas Matthijs (RETIRED)
Modified: 2011-10-30 23:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Matthijs (RETIRED) gentoo-dev 2005-07-19 13:21:00 UTC
there is some discution on irc about the inclusion keyword

Current desc: "Contains content that should be reviewed for integration. 
Patches, apps/scripts, etc.."

Some ppl seem to think it applies too all user submitted patches/etc
which is imo counters the keyword name 'inclusion' which implies it should be 
for things allready deemed correct/verified and should at one point be done/
applied/whatever

maybe add 'verified' ?
"Contains verified content that should be reviewed for integration. Patches, 
apps/scripts, etc..

I hope someone else can maybe think of a better description
If i am correct about the keyword meaning
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2005-07-19 14:28:19 UTC
(In reply to comment #0)

> Some ppl seem to think it applies too all user submitted patches/etc
> which is imo counters the keyword name 'inclusion' which implies it should be 
> for things allready deemed correct/verified and should at one point be done/
> applied/whatever

IMHO, it's not ambiguous, it's defined as it is, i.e. "contains content that
should be *reviewed* for integration..." and thus should be used according to
that definition. If someone uses it otherwise, then he should use/ask for
another keyword. ;p

> maybe add 'verified' ?
> "Contains verified content that should be reviewed for integration. Patches, 
> apps/scripts, etc..

OK, you want this only for maintainers' use? Then we could have something like
"Patch" for user submitted patches/scripts, or whatever... As I see it, this is
just a feature that makes searching for specific things in bugzilla easier;
whether someone likes it or dislikes it is purely matter of personal preferences.
 
> I hope someone else can maybe think of a better description
> If i am correct about the keyword meaning

As I said above, it is a keyword, defined by it's description. Could be as well
named "Patch" or "LookAtTheAttachment" and it wouldn't really matter. :)
Comment 2 Thomas Matthijs (RETIRED) gentoo-dev 2005-07-19 17:27:16 UTC
(In reply to comment #1)
> As I said above, it is a keyword, defined by it's description. Could be as 
well
> named "Patch" or "LookAtTheAttachment" and it wouldn't really matter. :)
> 

It does mather, if a keyword is not clearly defined and used for diffrend 
reasons it becomes completely useless.

If ppl(/you) want a keyword to mark user submitted patches, then make one that 
is obviously for that.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2005-07-20 00:28:01 UTC
(In reply to comment #2)
> 
> It does mather, if a keyword is not clearly defined and used for diffrend 
> reasons it becomes completely useless.
> 
> If ppl(/you) want a keyword to mark user submitted patches, then make one that 
> is obviously for that.

Well, I could care less... jforman, can we have "Patch" keyword (which somewhat
matches the EBUILD one), if that seems fit to axxo?
Comment 4 Marius Mauch (RETIRED) gentoo-dev 2005-08-22 06:36:23 UTC
Just for reference: "Inclusion" was originally added by carpaski to mark certain
portage related bugs that had usable patches/scripts/whatever (instead of the
usual I-want-stuff-but-don't-have-anything bugs), it wasn't even meant for the tree.
Comment 5 Thomas Matthijs (RETIRED) gentoo-dev 2005-09-08 06:46:30 UTC
nobody seems to care anymore, guess its just me