Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 99426 - x11-misc/skippy works on a AMD64 (with a patch)
Summary: x11-misc/skippy works on a AMD64 (with a patch)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High enhancement (vote)
Assignee: Jonathan Smith (RETIRED)
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2005-07-18 05:51 UTC by Eduardo
Modified: 2005-07-25 16:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild with amd64 patch support (skippy-0.5.0.ebuild,1.03 KB, text/plain; charset=us-ascii)
2005-07-19 16:47 UTC, Lionel Bouton
Details
patch to make skippy aware of the pointer length (amd64.patch,351 bytes, patch)
2005-07-19 16:49 UTC, Lionel Bouton
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo 2005-07-18 05:51:59 UTC
After tried the ebuild on my AMD64 I started to search in google and I found the
fix to make run this program on a AMD64. 

Just make a diff file to change wm.c file with this:

261c261
<               l = dlist_add(l, (void*)((CARD32*)data)[i]);
---
>               l = dlist_add(l, (void*)((CARD64*)data)[i]);


I hope in next bug reports I can do the corrected ebuild, sorry.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Gustavo Felisberto (RETIRED) gentoo-dev 2005-07-18 06:37:38 UTC
I'll take care of this. I noticed the warning at build time about incompatible
pointer type and the crash when starting. I'll try with this fix and if it works
patch the ebuild.
Comment 2 Lionel Bouton 2005-07-19 16:42:45 UTC
(In reply to comment #0)
> After tried the ebuild on my AMD64 I started to search in google and I found the
> fix to make run this program on a AMD64. 
> 
> Just make a diff file to change wm.c file with this:
> 
> 261c261
> <               l = dlist_add(l, (void*)((CARD32*)data)[i]);
> ---
> >               l = dlist_add(l, (void*)((CARD64*)data)[i]);
> 

IMHO it should be :

l = dlist_add(l, (void*)((void**)data)[i]);

which is portable. The patch above probably break all non-64-bit platforms.
Comment 3 Lionel Bouton 2005-07-19 16:47:33 UTC
Created attachment 63822 [details]
new ebuild with amd64 patch support
Comment 4 Lionel Bouton 2005-07-19 16:49:04 UTC
Created attachment 63823 [details, diff]
patch to make skippy aware of the pointer length
Comment 5 Jonathan Smith (RETIRED) gentoo-dev 2005-07-25 16:14:52 UTC
(In reply to comment #3)
> Created an attachment (id=63822) [edit]
> new ebuild with amd64 patch support
> 

next time, post a diff instead. diffs/ebuilds which just add epatch are also
unnecessary
Comment 6 Jonathan Smith (RETIRED) gentoo-dev 2005-07-25 16:31:33 UTC
fixed... thanks