Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 99399 - spamassassin-ruledujour has an instance of "head -1" (plus some other clean-ups)
Summary: spamassassin-ruledujour has an instance of "head -1" (plus some other clean-ups)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High minor (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2005-07-17 23:11 UTC by kfm
Modified: 2005-08-22 20:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
spamassassin-ruledujour-20050106-r1.diff (against previous ebuild) (spamassassin-ruledujour-20050106-r1.diff,2.46 KB, patch)
2005-07-17 23:13 UTC, kfm
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kfm 2005-07-17 23:11:44 UTC
Hi there. I've noticed that spamassassin-ruledujour script coughs up warnings
about using head in the deprecated manner which makes for a little noise in my
Inbox. This turns out to be as a result of line #102 which, unless $HEAD is
defined in the environment, opts to use the deprecated syntax.

I'm attaching a proposed diff against the current
mail-filter/spamassassin-ruledujour-20050106 which does three things:

1) Adds a dosed call to correct this issue.
2) Clean up the ebuild slightly. In particular the einfo text seemed less than
obvious to me and visually nondescript amid the noise of emerge at large. Used
ewarn for the situation where the old script exists (all lines fit within 73 chars).
3) Changed HOMEPAGE_URI, which would close bug 90791.

With regard to the use of ewarn, I'm suggesting that because I think it merits
the level of "warning" over mere informational text. This is useful for those
who filter through "etext" based on the level. For example, I use the 3rd party
enotice extension which is able to do this ... and that's the part I would want
to see if upgrading rather then the same old informational blurb.

Please consider committing this as a -r1 bump. Thanks.
Comment 1 kfm 2005-07-17 23:13:26 UTC
Created attachment 63672 [details, diff]
spamassassin-ruledujour-20050106-r1.diff (against previous ebuild)
Comment 2 kfm 2005-07-17 23:14:45 UTC
Also, I meant bug 98992 (rather than 90791).
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-08-22 20:24:15 UTC
I've taken a different route to fix this, but it will be in the tree shortly.