While playing Project: Starfighter, if your ship's capacity of plasma ammo is set to, or close to, the maximum the game will let you set (250), it's possible to pick up a power-up droplet (or whatever they're officially called) to add plasma ammo to what your ship currently has, where the sum would exceed 255. The plasma ammo is stored in an unsigned char, so this causes wraparound to a very low number, which can be quite disconcerting while you're in the thick of a fight and suddenly run out of ammo, when you had plenty only a moment before. There is code to limit the ammo to whatever your current ship's capacity is (say 250), but the check occurs after the addition of the droplet's ammo to your stockpile--i.e., after the overflow has already occurred. The solution is to do the addition in a wider temp variable (an int) and bounds-check there. Will upload a patch that does precisely this. This fixes the immediate case, though I see plenty of other cases where it's conceivable that such over/underflow could occur. I've tested this and it now Works For Me in the indicated case. If this passes muster here, it would be a good idea to pass this upstream.
Created attachment 63670 [details, diff] Patch for plasma ammo counter
Thanks for the patch and bug report. Added to CVS. resync/remerge to get the fix.
