Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 99060 - firefox: cherry picking on Fedora patches
Summary: firefox: cherry picking on Fedora patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Mozilla Gentoo Team
URL: http://cvs.fedora.redhat.com/viewcvs/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-14 18:06 UTC by TGL
Modified: 2005-09-28 04:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
01_firefox-1.0.5-fedora--minor_fixes.patch (01_firefox-1.0.5-fedora--minor_fixes.patch,3.43 KB, patch)
2005-07-14 18:06 UTC, TGL
Details | Diff
02_firefox-1.0.5-fedora--better_desktop_entry.patch (02_firefox-1.0.5-fedora--better_desktop_entry.patch,545 bytes, patch)
2005-07-14 18:06 UTC, TGL
Details | Diff
03_firefox-1.0.5-fedora--better_gnome_integration.patch (03_firefox-1.0.5-fedora--better_gnome_integration.patch,823 bytes, patch)
2005-07-14 18:07 UTC, TGL
Details | Diff
04_firefox-1.0.5-fedora--pango.patch (04_firefox-1.0.5-fedora--pango.patch,1.78 KB, patch)
2005-07-14 18:07 UTC, TGL
Details | Diff
01_firefox-1.0.5-fedora--minor_fixes.patch (01_firefox-1.0.5-fedora--minor_fixes.patch,3.08 KB, patch)
2005-07-14 18:20 UTC, TGL
Details | Diff
04_firefox-1.0.5-fedora--pango.patch (04_firefox-1.0.5-fedora--pango.patch,2.12 KB, patch)
2005-07-14 18:20 UTC, TGL
Details | Diff
01_firefox-1.0.6-r1-fedora--minor_fixes.patch (01_firefox-1.0.6-r1-fedora--minor_fixes.patch,2.71 KB, patch)
2005-07-22 09:18 UTC, TGL
Details | Diff
03_firefox-1.0.6-r1-fedora--better_gnome_integration.patch (03_firefox-1.0.6-r1-fedora--better_gnome_integration.patch,831 bytes, patch)
2005-07-22 09:19 UTC, TGL
Details | Diff
04_firefox-1.0.6-r1-fedora--pango.patch (04_firefox-1.0.6-r1-fedora--pango.patch,2.08 KB, patch)
2005-07-22 09:19 UTC, TGL
Details | Diff
01_firefox-1.0.6-r3-fedora--minor_fixes.patch (01_firefox-1.0.6-r3-fedora--minor_fixes.patch,2.43 KB, patch)
2005-07-24 05:18 UTC, TGL
Details | Diff
03_firefox-1.0.6-r3-fedora--better_gnome_integration.patch (03_firefox-1.0.6-r3-fedora--better_gnome_integration.patch,833 bytes, patch)
2005-07-24 05:19 UTC, TGL
Details | Diff
04_firefox-1.0.6-r3-fedora--pango.patch (04_firefox-1.0.6-r3-fedora--pango.patch,2.08 KB, patch)
2005-07-24 05:20 UTC, TGL
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description TGL 2005-07-14 18:06:00 UTC
I've tried various patches from the Fedora firefox package, and there are several interesting stuffs there. I will attach a serie of patches against the current 1.0.5 ebuild with some of them:

01_firefox-1.0.5-fedora--minor_fixes.patch and 02_firefox-1.0.5-fedora--better_desktop_entry.patch are some minor non-optionnal fixes, addition of a manpage, and improvement to the .desktop file (adds MIME handling declaration, so that Firefox is listed by Nautilus and others as an application to open HTML files).

03_firefox-1.0.5-fedora--better_gnome_integration.patch apply patches only if USE=gnome. They enable the GTK+ file selector, and other minor stuffs like URI handling by Gnome helper application ("man:foo" opens yelp, etc).

Finally, 04_firefox-1.0.5-fedora--pango.patch applies a set of patches for Pango rendering of text if USE=pango. It works, but i can't say i've seen any difference, so i only attach that one for information. Maybe some people who can read right-to-left written languages could test it and tell if it enhances anything for them...


Note that this report is somehow related to bug #89242 (Ubuntu patches, but it's too big imho) and bug #75404 (pango support too, but Fedora has additional fixes).
Comment 1 TGL 2005-07-14 18:06:24 UTC
Created attachment 63429 [details, diff]
01_firefox-1.0.5-fedora--minor_fixes.patch
Comment 2 TGL 2005-07-14 18:06:44 UTC
Created attachment 63430 [details, diff]
02_firefox-1.0.5-fedora--better_desktop_entry.patch
Comment 3 TGL 2005-07-14 18:07:08 UTC
Created attachment 63431 [details, diff]
03_firefox-1.0.5-fedora--better_gnome_integration.patch
Comment 4 TGL 2005-07-14 18:07:28 UTC
Created attachment 63432 [details, diff]
04_firefox-1.0.5-fedora--pango.patch
Comment 5 TGL 2005-07-14 18:20:26 UTC
Created attachment 63433 [details, diff]
01_firefox-1.0.5-fedora--minor_fixes.patch

Err... one chunk was in the wrong patch.
Comment 6 TGL 2005-07-14 18:20:48 UTC
Created attachment 63434 [details, diff]
04_firefox-1.0.5-fedora--pango.patch
Comment 7 TGL 2005-07-22 09:17:50 UTC
I will submit some new ebuild patches (#01, #03 and #04) rediffed for 1.0.6-r1.
The desktop entry patch (#02) is still valid.

About the Pango patches, I've found some test cases where it actually improves
rendering:
 - without Pango: http://tdegreni.free.fr/temp/firefox-tibetain-nopango.png
 - with Pango: http://tdegreni.free.fr/temp/firefox-tibetain-pango.png
The text is in Tibetan, using a font from
http://iris.lib.virginia.edu/tibet/xml/show.php?xml=/tools/tibfonts.xml&l=uva10928423419921
According to someone who can read Tibetan, only the Pango-enabled rendering is
correct (without Pango, some symbols overlaps horizontaly, and there are some
wrong vertical whitespaces too). I've been told that the same happens with any
Brahmi language, like Indian, Thai, Kmer, etc.
Comment 8 TGL 2005-07-22 09:18:36 UTC
Created attachment 64063 [details, diff]
01_firefox-1.0.6-r1-fedora--minor_fixes.patch
Comment 9 TGL 2005-07-22 09:19:02 UTC
Created attachment 64064 [details, diff]
03_firefox-1.0.6-r1-fedora--better_gnome_integration.patch
Comment 10 TGL 2005-07-22 09:19:27 UTC
Created attachment 64065 [details, diff]
04_firefox-1.0.6-r1-fedora--pango.patch
Comment 11 TGL 2005-07-24 05:18:45 UTC
Created attachment 64196 [details, diff]
01_firefox-1.0.6-r3-fedora--minor_fixes.patch
Comment 12 TGL 2005-07-24 05:19:34 UTC
Created attachment 64197 [details, diff]
03_firefox-1.0.6-r3-fedora--better_gnome_integration.patch
Comment 13 TGL 2005-07-24 05:20:02 UTC
Created attachment 64198 [details, diff]
04_firefox-1.0.6-r3-fedora--pango.patch
Comment 14 TGL 2005-09-28 04:00:02 UTC
All patches i had selected are now in firefox-1.0.7-r2
(mozilla-1.7.12-patches-1.0.tar.bz2), so i will close this bug. Many thanks Az'.

The only remaining part is the .desktop stuffs (MIME types associations), but i
will re-submit that as a new bug since it was not the main point of this one.
Comment 15 Martin Schlemmer (RETIRED) gentoo-dev 2005-09-28 04:33:10 UTC
Ugh, sorry, missed this bug.