Bug 98727 – ebuild.sh uses comma in arg to sleep

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Thor Kooda 2005-07-11 19:59:54 UTC]

/usr/lib/portage/bin/ebuild.sh uses "0,25" (note the comma) as an arg to `sleep`
on lines 872-875, when it's expecting an integer or floating point number.

This results in a simple error to stderr (quietly discarded to /dev/null) and no
real sleep.


Reproducible: Always
Steps to Reproduce:



Expected Results:  
I assume the author(s) intended to pass "0.25" (note the period) to sleep like
they did on the 4 lines immediately preceding the 4 lines in question.


Portage 2.0.51.22-r1 (default-linux/x86/2005.0, gcc-3.3.5-20050130,
glibc-2.3.4.20041102-r1, 2.6.11.11 i686)
=================================================================
System uname: 2.6.11.11 i686 AMD Athlon(tm) XP 2600+
Gentoo Base System version 1.6.12
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.5
sys-apps/sandbox:    1.2.10
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.5
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://gentoo.mirrors.tds.net/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X a52 aac acpi alsa apache2 apm arts avi berkdb bitmap-fonts bzip2 cdb
cdparanoia crypt cups curl dbus divx4linux dvb dvd dvdread emacs emboss encode
esd ethereal fam ffmpeg flac foomaticdb fortran ftp gdbm gif gnome gpm gtk gtk2
imagemagick imap imlib innodb java javascript jpeg kde libg++ libwww mad maildir
mbox mikmod mime motif mp3 mpeg mysql ncurses nls offensive ogg oggvorbis opengl
oss pam pcre pdflib perl php png python qt quicktime readline sdl sockets speex
spell ssl tcpd theora tiff truetype truetype-fonts type1-fonts v4l vcd vorbis
win32codecs xine xml xml2 xmms xpm xv xvid zlib userland_GNU kernel_linux
elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY

[Comment 1 Thor Kooda 2005-07-11 20:14:17 UTC]

Created attachment 63195 [details, diff]
trivial patch to replace commas with periods in arguments to sleep

[Comment 2 TGL 2005-07-12 06:30:28 UTC]

> I assume the author(s) intended to pass "0.25" (note the period) to sleep like
> they did on the 4 lines immediately preceding the 4 lines in question.

No. Depending on the locales, floats may be written with either a period (en_*
for instance) or a comma (fr_* for instance), hence the two sleep blocks (one
will actually sleep, and the other will just produce a few error messages for
/dev/null).

[Comment 3 SpanKY 2005-07-12 11:24:19 UTC]

`LC_ALL=C sleep 0.25` should work for everyone then

[Comment 4 Alec Warner (RETIRED) 2005-10-18 07:34:08 UTC]

This is fixed in rc5, I am not sure exactly when the fix occured.