Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 97961 - prettify and fix lib -> $(get_libdir) in the windowmaker ebuilds
Summary: prettify and fix lib -> $(get_libdir) in the windowmaker ebuilds
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Gnustep project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-04 23:25 UTC by Georgi Georgiev
Modified: 2005-07-06 16:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgi Georgiev 2005-07-04 23:25:00 UTC
There are a couple of sed-s in the windowmaker ebuilds that are a bit hard to read. They have a lot of "\/" which could easily be avoided by using a different separator.

Also a lib should become $(get_libdir) in one of the seds. Please consider the following patch:

@@ -92,20 +119,23 @@   
        for file in ${S}/WindowMaker/*menu*; do
                if [ -r $file ]; then
                        if use gnustep ; then
-                               sed -e "s/\/usr\/local\/GNUstep/`cat ${TMP}/sed.gs_prefix`System/g;
-                                       s/XXX_SED_FSLASH/\//g;" < $file > $file.tmp
+                               sed -e "s:/usr/local/GNUstep:`cat ${TMP}/sed.gs_prefix`System:g;" \
+                                       -e "s:XXX_SED_FSLASH:/:g;" < $file > $file.tmp
                        else
-                               sed -e 's/\/usr\/local\/GNUstep/\/usr\/lib\/GNUstep/g;' < $file > $file.tmp
+                               sed -e "s:/usr/local/GNUstep:/usr/$(get_libdir)/GNUstep:g;" < $file > $file.tmp
                        fi
                        mv $file.tmp $file;

-                       sed -e 's/\/usr\/local\/share\/WindowMaker/\/usr\/share\/WindowMaker/g;' < $file > $file.tmp;
+                       sed -e 's:/usr/local/share/WindowMaker:/usr/share/WindowMaker:g;' < $file > $file.tmp;
                        mv $file.tmp $file;
                fi;
        done;
Comment 1 Armando Di Cianno (RETIRED) gentoo-dev 2005-07-06 16:09:08 UTC
thanks for the cleanup ... it is about 100x nicer with the different seperators :-)

fixes in portage