Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 97857 - KDE support in workrave 1.8
Summary: KDE support in workrave 1.8
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Leonardo Boshell (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-03 16:30 UTC by Gabi Shaar
Modified: 2005-08-11 09:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to get kde-applet working (workrave-1.8.0.patch,315 bytes, patch)
2005-08-09 00:11 UTC, Ruth Alkema
Details | Diff
workrave-1.8.1.ebuild.patch (workrave-1.8.1.ebuild.patch,1.10 KB, patch)
2005-08-09 01:56 UTC, Leonardo Boshell (RETIRED)
Details | Diff
workrave-1.8.1.ebuild.patch (workrave-1.8.1.ebuild.patch,1.40 KB, patch)
2005-08-10 03:17 UTC, Leonardo Boshell (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabi Shaar 2005-07-03 16:30:08 UTC
tried to emerge workrave-1.8.0 with kde support. ./configure failed to find kde
headers.




Reproducible: Always
Steps to Reproduce:
1. enable kde flag for workrave
(my flags are : -dbus -debug -distribution +gnome +kde +nls +xml2, but same
result with only kde flag enabled)
2. unmask workrave-1.8 ~x86
3. emerge workrave

Actual Results:  
configure failed :

checking for KDE... configure: error:
in the prefix, you've chosen, are no KDE headers installed. This will fail.
So, check this please and use another prefix!

Expected Results:  
workrave installed with kde support (kicker applet etc.)

workaround :
after disabling kde flag workrave builds and installs fine. only kde applet not
installed, but does not prevent app from working as intended.
Comment 1 Leonardo Boshell (RETIRED) gentoo-dev 2005-07-04 12:06:42 UTC
Thanks for your report. I made a mistake including that USE flag without testing it.

I removed it for now until someone provides a patch that enables KDE support
correctly. I'll have to rely on other people's help in this regard since I can't
test things with qt/kde.
Comment 2 Leonardo Boshell (RETIRED) gentoo-dev 2005-08-07 04:43:11 UTC
I'll add the proper support for the 'kde' flag if someone gives me a hand with
it. Resolving as WONTFIX for now.
Comment 3 Ruth Alkema 2005-08-09 00:11:35 UTC
Created attachment 65503 [details, diff]
patch to get kde-applet working

Hi, I have been able to compile it with kde-applet.
I attach the patch I made to the ebuild.
There is still one problem with it, when you emerge workrave you will get the
error:
open_wr: /usr/qt/3/etc/settings/.qtrc.lock 
see also http://forums.gentoo.org/viewtopic.php?t=18733

I solved this by removing the /usr/qt/3/etc directory
Comment 4 Leonardo Boshell (RETIRED) gentoo-dev 2005-08-09 01:43:47 UTC
Thanks for the contribution, I'll look into your patch in a moment.
Comment 5 Leonardo Boshell (RETIRED) gentoo-dev 2005-08-09 01:56:11 UTC
Created attachment 65506 [details, diff]
workrave-1.8.1.ebuild.patch

The patch looks fine. A few observations:

* Dependencies should be modified accordingly.
* Running external commands such as 'kde-config' from the global scope is a bad
idea, so I'd move that line to pkg_setup().
* I'm not sure about this, but setting --prefix to the output from `kde-config
--prefix` might affect the installation targets for other files that should
rely on --prefix=/usr. I suspect it's more appropriate to use --with-qd-dir
instead.

I'm attaching the resulting patch. Please test it and let me know how it goes.

I also have a couple of things I'd like to ask you about before committing a
new revision:

* What package provides the kde-config binary? It should be included in DEPEND
as well.
* Does the sandbox issue persist? If it's a real problem I'd like to find the
way to fix it so people don't have to use work-arounds such as removing
directories before running emerge.

Thank you.
Comment 6 Ruth Alkema 2005-08-09 02:31:28 UTC
I have tried your patch, but if you use '--with-qt-dir' then it fails to find
the necessary qt-binaries. 
I have also tried --with-extra-libs but that doesn't work either.
Also the error especially says that in the prefix no KDE errors are installed:

> checking for KDE... configure: error:
> in the prefix, you've chosen, are no KDE headers installed. This will fail.
> So, check this please and use another prefix!

So I suppose that --prefix is what we should have.

Further: kde-config is in kde-base/kdelibs.

The sandbox problem is still there, I don't know what to do about it, other than
throwing away the /usr/qt/3/etc dir.  I have looked into the eclass kde.eclass,
as was suggested in the forum, but I couldn't create a working ebuild with that
information.
Comment 7 Leonardo Boshell (RETIRED) gentoo-dev 2005-08-10 03:17:36 UTC
Created attachment 65587 [details, diff]
workrave-1.8.1.ebuild.patch

Thank you for the information.

I've finally had the chance to do a little testing with KDE packages and I
prepared a new ebuild which I think resolves all the remaining problems.

Please test it and let me know any problems/suggestions.

Thanks.
Comment 8 Ruth Alkema 2005-08-11 04:49:51 UTC
Yes, it works now. Thanks.
Comment 9 Leonardo Boshell (RETIRED) gentoo-dev 2005-08-11 09:09:47 UTC
Thank you. Committed now as workrave-1.8.1-r1.