gnome2_src_install does an einstall or make install without checking the exit code. If make dies, either because of an ebuild or package bug or because of a misconfigured/broken system, it will happily merge the bits that did get installed to the fs and carry on. This can cause weird bugs. The eclass should probably call die if make fails. Reproducible: Didn't try Steps to Reproduce: 1. cause an ebuild using gnome2.eclass to fail in the install stage (either by using a broken ebuild or by doing something weird to the system (setting the clock a while in the past for instance)) Actual Results: Merge "succeeded" Expected Results: Merge should have failed. I will attach a patch that adds the || die, but I haven't tested this nearly as much as is probably needed for a change to an important eclass like this.
Created attachment 62503 [details, diff] patch to gnome2.eclass, adding || die in src_install
*** Bug 87815 has been marked as a duplicate of this bug. ***
This is a good suggestion. Apparently it's very rare seeing a package that inherits from gnome2.eclass fail in the middle of "make install", but when it happens it should certainly break the emerge process. I'm not sure if omitting the '|| die' syntax was deliberate but I think it was probably involuntary. Marien, Have you been testing your modified eclass in your system?
gnome 2 is so good it never fails & I didn't want to be confronted with my mortality. fixed now, thanks.
