Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 96978 - bridge utils initscript fails to handle bridge names with '-' on them
Summary: bridge utils initscript fails to handle bridge names with '-' on them
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-24 12:53 UTC by pedro venda
Modified: 2005-07-02 18:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pedro venda 2005-06-24 12:53:35 UTC
bridge utils initscript fails to start with some errors when using a bridge 
name with the '-' char, like xen-br0. 
 
it is allways reproducible on bridge-utils 0.9.6-r1 and below. 
 

Reproducible: Always
Steps to Reproduce:
1. edit /etc/conf.d/bridge 
2. add line bridge="xen-br0" 
3. add line bridge_xen-br0_interfaces="eth1" 
4. run /etc/init.d/bridge restart 
 
Actual Results:  
xen ~ # /etc/init.d/bridge restart 
/etc/conf.d/bridge: line 10: bridge_xen-br0_devices=eth1: command not found 
 * Create Bridge xen-br0 ... 
interface br0_devices does not exist! 
SIOCSIFADDR: No such device 
br0_devices: unknown interface: No such device 
br0_devices: unknown interface: No such device 
 * Failed to set up interface br0_devices                                 
[ !! ] 
xen ~ #  

Expected Results:  
xen ~ # /etc/init.d/bridge start 
 * Create Bridge xen-br0 ... 
 

brctl can perfectly handle bridge names with dashes on them, which makes me   
think this is a bug in the initscript parser or such. somehow the initscript  
seems to see xen-br0 as br0 on the bridge_xen-br0_devices configuration line.  
  
couldn't test more recent versions of the bridge-utils, but I'll be able to do  
so next week.  
   
xen ~ # emerge info   
Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-3.3.5-20050130,   
glibc-2.3.4.200   
41102-r1, 2.6.11.10-xen0 i686)   
=================================================================   
System uname: 2.6.11.10-xen0 i686 Intel(R) Xeon(TM) CPU 3.00GHz   
Gentoo Base System version 1.6.12   
Python:              dev-lang/python-2.3.5 [2.3.5 (#1, Jun  9 2005, 15:53:49)]   
ccache version 2.3 [enabled]   
dev-lang/python:     2.3.5   
sys-apps/sandbox:    [Not Present]   
sys-devel/autoconf:  2.59-r6, 2.13   
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.5   
sys-devel/binutils:  2.15.92.0.2-r10   
sys-devel/libtool:   1.5.16   
virtual/os-headers:  2.6.8.1-r2   
ACCEPT_KEYWORDS="x86"   
AUTOCLEAN="yes"   
CFLAGS="-O2 -march=pentium4 -fomit-frame-pointer -pipe -O2"   
CHOST="i686-pc-linux-gnu"   
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/lib/X1   
1/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/   
config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/   
 /usr/share/texmf/xdvi/ /var/qmail/control"   
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"   
CXXFLAGS="-O2 -march=pentium4 -fomit-frame-pointer -pipe -O2"   
DISTDIR="/usr/portage/distfiles"   
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms strict"   
GENTOO_MIRRORS="ftp://ftp.rnl.ist.utl.pt/gentoo"   
MAKEOPTS="-j5"   
PKGDIR="/usr/portage/packages"   
PORTAGE_TMPDIR="/var/tmp"   
PORTDIR="/usr/portage"   
SYNC="rsync://ftp.rnl.ist.utl.pt/gentoo-portage"   
USE="x86 X acl acpi apache2 apm arts avi berkdb bitmap-fonts bzlib cpdflib   
crypt   
 cscope ctype cups curl emboss encode fam foomaticdb fortran freetype ftp gd   
gdb   
m gif gmp gpm gtk gtk2 iconv imagemagick imlib ipv6 java jpeg libedit libg++   
lib   
www mad mhash mikmod mmx motif mp3 mpeg mysql ncurses nls oggvorbis opengl oss   
p   
am pdflib perl php plotutils png python quicktime readline sdl snmp spell sse   
ss   
l svga tcpd tetex tiff truetype truetype-fonts type1-fonts xml xml2 xmms xpm   
xv    
zlib userland_GNU kernel_linux elibc_glibc"   
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS,   
PORTDIR_OVERLA   
Y   
   
xen ~ #
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-07-02 12:11:58 UTC
the init scripts for the old bridge-utils are deprecated. 
please use the stuff with the new baselayout.
the old packages will be going away soon (as soon as sysfsutils-1.2 goes 
stable).
Comment 2 pedro venda 2005-07-02 16:59:15 UTC
"the init scripts for the old bridge-utils are deprecated." 
 
sorry, don't follow. the currently stable are actually old and deprecated? 
 
"please use the stuff with the new baselayout." 
 
I think I already am. 
 
"the old packages will be going away soon (as soon as sysfsutils-1.2 goes  
stable)." 
 
you mean after sysfsutils-1.2 goes stable baselayout will be updated into 
1.12.0? 
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-07-02 18:32:53 UTC
baselayout-1.11 has it's own support for bridging, without 
needing /etc/init.d/bridge.

The new bridge-utils links against >sysfsutils-1.0, so sysfutils needs to be 
stable before bridge-utils can go stable.

I've put a 0.9.6-r2 into the tree as stable on x86 also telling users to use 
the new baselayout stuff.

For the new baselayout stuff, it's entirely in /etc/conf.d/net 
and /etc/init.d/net.$DEVICE

/etc/{conf,init}.d/bridge is not used anymore at all.