Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 96559 - bcm4400 under 2.6.12: pci.h no longer has struct pci_dev member slot_name
Summary: bcm4400 under 2.6.12: pci.h no longer has struct pci_dev member slot_name
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: http://lkml.org/lkml/2005/3/4/337
Whiteboard:
Keywords:
: 116294 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-19 16:45 UTC by Philip Kovacs
Modified: 2005-12-21 09:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bcm4400-3.0.8-r1.ebuild (bcm4400-3.0.8-r1.ebuild,967 bytes, text/plain)
2005-06-19 16:46 UTC, Philip Kovacs
Details
files/bcm4400-3.0.8-pci_name.patch (bcm4400-3.0.8-pci_name.patch,415 bytes, text/plain)
2005-06-19 16:47 UTC, Philip Kovacs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Kovacs 2005-06-19 16:45:36 UTC
kernel 2.6.12 pci.h has made obsolete any reference to struct pci_dev's
slot_name.  pdev->slot_name needs to be replaced with pci_name(pdev).  the
bcm4400 module will no longer compile.  i am attaching a new ebuild and a patch
file.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Philip Kovacs 2005-06-19 16:46:31 UTC
Created attachment 61530 [details]
bcm4400-3.0.8-r1.ebuild
Comment 2 Philip Kovacs 2005-06-19 16:47:17 UTC
Created attachment 61531 [details]
files/bcm4400-3.0.8-pci_name.patch
Comment 3 Philip Kovacs 2005-06-19 20:01:19 UTC
i have made Broadcom aware of this problem and given them the patch.  They have
acknowledged it and are planning to patch their driver (upstream).
Comment 4 Stefan Schweizer (RETIRED) gentoo-dev 2005-06-20 04:59:29 UTC
Can you please attach a unified diff when you make changes to an ebuild instead
of the full ebuild?
Otherwise the changes are ok, thanks, fixed.
Comment 5 Daniel Drake (RETIRED) gentoo-dev 2005-06-20 10:04:40 UTC
Out of interest, why do you use this driver? Isn't there an in-kernel version?
Comment 6 Philip Kovacs 2005-06-20 10:07:36 UTC
Daniel,

At the time I began using it, there were issues with b44, the in-kernel module.
  I have no preference now either way, just force of habit.  Is b44 > bcm4400 now?

Phil
Comment 7 Daniel Drake (RETIRED) gentoo-dev 2005-06-20 11:14:32 UTC
It's just easier and nicer for the drivers to be included in the kernel. Would
avoid running into problems like this for a start.

It would be worth testing b44 on 2.6.12 and filing bugs at
http://bugzilla.kernel.org if you have the time.
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2005-12-21 09:42:13 UTC
*** Bug 116294 has been marked as a duplicate of this bug. ***