Bug 96212 – xlockmore-5.18 refuses to unlock

• Status: RESOLVED LATER
• Product: Gentoo Linux

[Description Jonathan Smith (RETIRED) 2005-06-15 14:14:33 UTC]

i've seen too many reports of this to ignore... it seems to be unrelated to bug 93159, but we can't be sure

[Comment 1 Jonathan Smith (RETIRED) 2005-06-15 14:18:39 UTC]

5.18 is p.mask'd due to this issue

[Comment 2 Jonathan Smith (RETIRED) 2005-06-16 17:48:25 UTC]

xlockmore-5.17 works, so that is ~arch'd in the tree... still working on 5.18

[Comment 3 Marcelo Goes (RETIRED) 2005-06-23 16:39:53 UTC]

Created attachment 61810 [details, diff]
xlockmore-5.18-passwd.diff

I am going to try to narrow this problem down, but this worked for me.

[Comment 4 Marcelo Goes (RETIRED) 2005-06-23 18:05:40 UTC]

Alright, basically commenting out the line "pam_error = pam_acct_mgmt(pamh, 0);"
from passwd.c seems to fix the problem.

Now, if you really want to be amused, the following fixed the problem for me
too. Add the line "fprintf("debugz0r: %s/n", &pam_error);" bellow "pam_error =
pam_acct_mgmt(pamh, 0);" and it may actually work as well. Don't ask why.

[Comment 5 Jonathan Smith (RETIRED) 2005-06-25 16:13:19 UTC]

this sed magic went into 5.18-r2 (and a call for testing on -dev ML to ensure
that it works for everyone)

sed -e '/pam_error = pam_acct_mgmt(pamh, 0);/a\
	fprintf("stupid pam fix %s/n", &pam_error);' \
	-i passwd.c

[Comment 6 Krzysztof Pawlik (RETIRED) 2005-06-25 16:42:24 UTC]

fprintf() takes a FILE pointer as first agrument, so:

fprintf(stderr, ...

or

printf(...

[Comment 7 Jonathan Smith (RETIRED) 2005-06-25 17:09:37 UTC]

using printf causes the bug to reappear

[Comment 8 Jonathan Smith (RETIRED) 2005-07-02 18:01:58 UTC]

bah, i think i'm just going to wait for 5.19 to come out (upstream dev says it
should be pretty soon)

for now, 5.17 works just dandy

[Comment 9 Jonathan Smith (RETIRED) 2005-07-02 18:02:56 UTC]

marking LATER