After installing sys-process/atop-1.13, I ran '/etc/init.d/atop start' (as root), which came back with: /etc/init.d/atop: line 22: syntax error near unexpected token `fi' /etc/init.d/atop: line 22: ` fi' * ERROR: "/etc/init.d/atop" has syntax errors in it; not executing... I examined the file and couldn't find the exact error, but I'm not a bash expert. I did notice the use of {}; $PIDATOP in stead of ${PIDATOP} which is a typical example of sloppy programming. Hope the init.d script for atop can be reviewed and fixed. Reproducible: Always Steps to Reproduce: 1. emerge atop 2. /etc/init.d/atop start Actual Results: /etc/init.d/atop: line 22: syntax error near unexpected token `fi' /etc/init.d/atop: line 22: ` fi' * ERROR: "/etc/init.d/atop" has syntax errors in it; not executing... Expected Results: It should have started the atop background process Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-3.3.5-20050130, glibc-2.3.4.20041102-r1, 2.6.11-gentoo-r9 i686) ================================================================= System uname: 2.6.11-gentoo-r9 i686 Pentium III (Coppermine) Gentoo Base System version 1.6.12 Python: dev-lang/python-2.3.5 [2.3.5 (#1, Jun 8 2005, 19:30:01)] ccache version 2.3 [enabled] dev-lang/python: 2.3.5 sys-apps/sandbox: [Not Present] sys-devel/autoconf: 2.13, 2.59-r6 sys-devel/automake: 1.5, 1.8.5-r3, 1.6.3, 1.7.9-r1, 1.4_p6, 1.9.5 sys-devel/binutils: 2.15.92.0.2-r10 sys-devel/libtool: 1.5.16 virtual/os-headers: 2.6.8.1-r2 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CFLAGS="-march=pentium3 -O3 -pipe -fomit-frame-pointer -ftracer -fforce-addr -fprefetch-loop-arrays -falign-functions=4" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-march=pentium3 -O3 -pipe -fomit-frame-pointer -ftracer -fforce-addr -fprefetch-loop-arrays -falign-functions=4" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms strict userpriv usersandbox" GENTOO_MIRRORS="http://ftp.snt.utwente.nl/pub/os/linux/gentoo http://ftp.easynet.nl/mirror/gentoo/" LANG="nl_NL.UTF-8" LC_ALL="nl_NL.UTF-8" LDFLAGS="-Wl,-O1" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="x86 3dfx X aalib acpi alsa apache2 apm arts audiofile avi berkdb bitmap-fonts crypt cups divx4linux doc emboss encode flash foomaticdb fortran ftp gdbm gif gnome gpm gstreamer gtk gtk2 imlib ipv6 java javascript jpeg kde kerberos krb4 libg++ libwww mad mbox mikmod mmx mng motif mozilla mp3 mpeg msn ncurses nls nptl offensive ogg oggvobis oggvorbis opengl oss pam pdflib perl php pic png posix python qt quicktime readline samba sdl sharedmem spell ssl svg svga symlink tcltk tcpd tidy tiff truetype truetype-fonts type1-fonts usb videos vorbis win32codecs xine xml xml2 xmms xpm xprint xv xvid zlib userland_GNU kernel_linux elibc_glibc" Unset: ASFLAGS, CBUILD, CTARGET, LINGUAS
The script is missing a "; then". This: if [ "$PIDATOP" != "" ] kill $PIDATOP fi Should be this: if [ "$PIDATOP" != "" ]; then kill $PIDATOP fi
Please use "New -> Gentoo Linux -> Component: Ebuilds" in future. Infrastructure is not the correct addressee.
Sorry for any inconvinience, thought I had the right addressee :-S Will the "${PN}-${ATOP_INIT_VERSION}-initscript" (as it is called in the ebuild) be modified or shall I submit a revised version through the proper (bug)channels?
moved the init script off of gentoo mirrors and into $FILESDIR cleaning it up as i did
