Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 95816 - sound-juicer ebuild should use cdr/dvdr USE flags.
Summary: sound-juicer ebuild should use cdr/dvdr USE flags.
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 95548
  Show dependency tree
 
Reported: 2005-06-11 17:24 UTC by Kris Kelley
Modified: 2005-07-12 21:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kris Kelley 2005-06-11 17:24:45 UTC
The current sound-juicer 2.10.0 ebuild depends unconditionally on
nautilus-cd-burner.  This means any system with a Gnome installation will have
CDR software installed, even those systems with the "cdr" and "dvdr" USE flags
explicity unset.

sound-juicer should instead conditionally depend on nautilus-cd-burner,
depending on whether the "cdr" or "dvdr" USE flags are set.

Reproducible: Always
Steps to Reproduce:
1.  Unset the "cdr" and "dvdr" USE flags
2.  Run "emerge -p --emptytree" gnome
3.  Note the inclusion of CD burning packages, including nautilus-cd-burner and
    cdrtools.
Comment 1 foser (RETIRED) gentoo-dev 2005-06-13 11:45:25 UTC
makes sense for now (s-j is planned to be more than a burner alone).
Comment 2 Leonardo Boshell (RETIRED) gentoo-dev 2005-07-07 20:42:32 UTC
Sound-juicer is a CD ripper and doesn't have any burner functionality (at least
for now), but it has to depend unconditionally on nautilus-cd-burner, since it
uses its library to detect and handle the CD drive as part of its preferences.
Other applications, like totem, do the same.

What we could do is enclose 'virtual/cdrtools' in a 'cdr? ()' block in the list
of dependencies for nautilus-cd-burner, similar to the app-cdr/dvd+rw-tools
dependency which is inside a 'dvdr? ()' block.
Comment 3 Leonardo Boshell (RETIRED) gentoo-dev 2005-07-12 21:02:57 UTC
The dependencies for nautilus-cd-burner have been adjusted and now
virtual/cdrtools should be pulled in only if the 'cdr' USE flag is enabled.

Now "USE='-cdr -dvdr' emerge -ep gnome" shouldn't list cdrtools or dvd+rw-tools.

However, since this bug refers specifically to sound-juicer's dependency on
nautilus-cd-burner, I'm resolving this as UPSTREAM. It would require a
significant amount of work to change sound-juicer's code to make it not depend
on libnautilus-burn.