Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 955901 - net-im/telegram-desktop: consider this patch for a new USE flag "open-this-link-confirmation-drop"
Summary: net-im/telegram-desktop: consider this patch for a new USE flag "open-this-li...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Esteve Varela Colominas
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-13 06:11 UTC by Vitaly Zdanevich
Modified: 2025-05-13 21:48 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Zdanevich 2025-05-13 06:11:29 UTC
diff --git i/Telegram/SourceFiles/core/click_handler_types.cpp w/Telegram/SourceFiles/core/click_handler_types.cpp
index 9e290988f..503fe050a 100644
--- i/Telegram/SourceFiles/core/click_handler_types.cpp
+++ w/Telegram/SourceFiles/core/click_handler_types.cpp
@@ -119,21 +119,21 @@ void HiddenUrlClickHandler::Open(QString url, QVariant context) {
 		|| url.startsWith(u"internal:"_q, Qt::CaseInsensitive)) {
 		UrlClickHandler::Open(url, QVariant::fromValue([&] {
 			auto result = context.value<ClickHandlerContext>();
 			result.mayShowConfirmation = !base::IsCtrlPressed();
 			return result;
 		}()));
 	} else {
 		const auto parsedUrl = url.startsWith(u"tonsite://"_q)
 			? QUrl(url)
 			: QUrl::fromUserInput(url);
-		if (UrlRequiresConfirmation(parsedUrl) && !base::IsCtrlPressed()) {
+		if (false && !base::IsCtrlPressed()) {
 			const auto my = context.value<ClickHandlerContext>();
 			if (!my.show) {
 				Core::App().hideMediaView();
 			}
 			const auto displayed = parsedUrl.isValid()
 				? parsedUrl.toDisplayString()
 				: url;
 			const auto displayUrl = !IsSuspicious(displayed)
 				? displayed
 				: parsedUrl.isValid()

Related upstream issue https://github.com/telegramdesktop/tdesktop/issues/16166
Comment 1 Esteve Varela Colominas 2025-05-13 19:52:54 UTC
Thanks, but I'm not open to maintaining optional patches to telegram-desktop. I maintain a few myself[1], though, and I'd be interested in seeing a patch repository for gentoo, or something like that, to give things like this more visibility. (sidenote but please let me know if there's any patches to remove the ads, would be really nice)

[1]: https://github.com/mid-kid/gentoo-config/tree/master/patches/net-im/telegram-desktop
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-05-13 21:48:44 UTC
(In reply to Vitaly Zdanevich from comment #0)

Please put local patches in /etc/portage/patches unless there's serious merit for it being in the ebuild. Especially if it would have to be applied conditionally.