Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 955482 - x11-wm/xpra-6.0.1-r1: error: code will never be executed [-Werror,-Wunreachable-code]
Summary: x11-wm/xpra-6.0.1-r1: error: code will never be executed [-Werror,-Wunreachab...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Benda Xu
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2025-05-05 20:50 UTC by eroen
Modified: 2025-05-09 07:52 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
x11-wm:xpra-6.0.1-r1:20250505-204054.log (x11-wm:xpra-6.0.1-r1:20250505-204054.log,253.35 KB, text/x-log)
2025-05-05 20:50 UTC, eroen
Details
emerge --info etc. (file_955482.txt,17.24 KB, text/plain)
2025-05-05 20:51 UTC, eroen
Details
x11-wm:xpra-6.0.1-r1:20250505-211646.log (x11-wm:xpra-6.0.1-r1:20250505-211646.log,254.83 KB, text/x-log)
2025-05-05 21:20 UTC, eroen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description eroen 2025-05-05 20:50:17 UTC
Created attachment 927781 [details]
x11-wm:xpra-6.0.1-r1:20250505-204054.log

This is with clang 20.1.4.

It looks like several files fail to compile with errors like these:

xpra/x11/bindings/xwait.c:7030:17: error: fallthrough annotation in
      unreachable code [-Werror,-Wunreachable-code-fallthrough]
 7030 |                 CYTHON_FALLTHROUGH;
      |                 ^
xpra/x11/bindings/xwait.c:615:34: note: expanded from macro
      'CYTHON_FALLTHROUGH'
  615 |       #define CYTHON_FALLTHROUGH __attribute__((fallthrough))
      |                                  ^


xpra/codecs/v4l2/virtual.c:15174:17: error: fallthrough annotation in
      unreachable code [-Werror,-Wunreachable-code-fallthrough]
 15174 |                 CYTHON_FALLTHROUGH;
       |                 ^
xpra/codecs/v4l2/virtual.c:617:34: note: expanded from macro
      'CYTHON_FALLTHROUGH'
  617 |       #define CYTHON_FALLTHROUGH __attribute__((fallthrough))
      |                                  ^


xpra/net/rencodeplus/rencodeplus.c:13431:13: error: code will never be
      executed [-Werror,-Wunreachable-code]
 13431 |             PyErr_SetString(PyExc_OverflowError, "%c arg not in range(0x110000)");
       |             ^~~~~~~~~~~~~~~


and finally:

error: command '/usr/lib/llvm/20/bin/clang' failed with exit code 1


See also bug 934033 - x11-wm/xpra-6.0.1-r1 adds -Werror flag on its own
Comment 1 eroen 2025-05-05 20:51:55 UTC
Created attachment 927782 [details]
emerge --info etc.
Comment 2 eroen 2025-05-05 21:07:26 UTC
`-Werror` was disabled on 2023-05-16 by changing `--with-strict` to `--without-strict` in [0], closing bug 906343.

`--with-strict` was reintroduced in [1] on 2024-06-10, without explicit mention in the commit message.

[0]:https://gitweb.gentoo.org/repo/gentoo.git/commit/x11-wm/xpra?id=26532a745e96a2bcd4cab5e8d4a469133cec7055
[1]: https://gitweb.gentoo.org/repo/gentoo.git/commit/x11-wm/xpra?id=dcc3756596141e0080544618e18f1152bf0be774
Comment 3 eroen 2025-05-05 21:20:07 UTC
Created attachment 927783 [details]
x11-wm:xpra-6.0.1-r1:20250505-211646.log

I just realized the bug 948461 error is also present, uploading build log with patch applied.