>>> Test phase: net-p2p/syncthing-1.29.5 WORK=/var/tmp/portage/net-p2p/syncthing-1.29.5/temp/go-build2898113506 /var/tmp/portage/net-p2p/syncthing-1.29.5/temp/go-build/e7/e78b0f62131268f0fff3ab52609a2c16b855734c541c4a1109916ca71dd5206b-d/build test -buildmode=pie not supported when -race is enabled on linux/amd64 exit status 1 exit status 1 * ERROR: net-p2p/syncthing-1.29.5::gentoo failed (test phase): * test failed --- $ emerge --info Portage 3.0.68-4+g6a2bd8589-dirty (python 3.13.3-final-0, default/linux/amd64/23.0/hardened, gcc-16, glibc-2.41.9999, 6.14.5 x86_64) ================================================================= System uname: Linux-6.14.5-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.41 KiB Mem: 65737596 total, 15538540 free KiB Swap: 16662520 total, 15031340 free Timestamp of repository gentoo: Mon, 05 May 2025 07:09:27 +0000 Head commit of repository gentoo: dea329b33330da5f0fcd97a6213d0c4f220a5283 Timestamp of repository kde: Sat, 03 May 2025 22:54:44 +0000 Head commit of repository kde: 9afbfd6b82e3f40d581e89237f293d80d8c9c400 Timestamp of repository qt: Thu, 24 Apr 2025 20:35:11 +0000 Head commit of repository qt: 27210069680334182c0ebf5302465e79d472a2a0 Timestamp of repository sam_c: Fri, 02 May 2025 04:42:13 +0000 Head commit of repository sam_c: 8a582c23d42abe58b66dcc5450346ea47b8477b6 sh dash 0.5.12-r1 ld GNU ld (Gentoo 9999 p1) 2.44.50.20250505 ccache version 4.11.3 [disabled] app-misc/pax-utils: 1.3.8::gentoo app-shells/bash: 5.3_rc1_p20250430::gentoo dev-build/autoconf: 2.13-r8::gentoo, 2.69-r9::gentoo, 2.72-r1::gentoo, 9999::gentoo dev-build/automake: 1.17-r2::gentoo dev-build/cmake: 3.31.7::gentoo dev-build/libtool: 2.5.4::gentoo dev-build/make: 4.4.1-r100::gentoo dev-build/meson: 9999::gentoo dev-java/java-config: 2.3.4::gentoo dev-lang/perl: 5.40.2::gentoo dev-lang/python: 3.11.12::gentoo, 3.12.10::gentoo, 3.13.3::gentoo, 3.13.3-r100::gentoo dev-lang/rust: 1.86.0-r1::gentoo dev-util/ccache: 4.11.3::gentoo llvm-core/clang: 18.1.8-r6::gentoo, 19.1.7::gentoo, 20.1.3::gentoo llvm-core/lld: 20.1.3::gentoo llvm-core/llvm: 18.1.8-r6::gentoo, 19.1.7::gentoo, 20.1.3::gentoo sys-apps/baselayout: 2.17::gentoo sys-apps/sandbox: 2.46::gentoo sys-apps/systemd: 257.5::gentoo sys-devel/binutils: 2.38-r2::gentoo, 2.39-r5::gentoo, 2.40-r9::gentoo, 2.41-r5::gentoo, 2.42-r2::gentoo, 2.43-r2::gentoo, 2.44::gentoo, 9999::gentoo sys-devel/binutils-config: 5.5.2::gentoo sys-devel/gcc: 10.5.0::gentoo, 11.5.0::gentoo, 12.4.1_p20250430::gentoo, 13.3.1_p20250501::gentoo, 14.2.1_p20250502::gentoo, 15.1.1_p20250426::gentoo, 16.0.9999::gentoo sys-devel/gcc-config: 2.12.1::gentoo sys-kernel/linux-headers: 6.14::gentoo (virtual/os-headers) sys-libs/glibc: 2.41.9999::sam_c Repositories: gentoo location: /var/db/repos/gentoo sync-type: git sync-uri: https://github.com/gentoo-mirror/gentoo.git priority: -1000 eclass-overrides: sam_c volatile: False sync-git-verify-commit-signature: yes sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now crossdev location: /var/db/repos/crossdev masters: gentoo eclass-overrides: sam_c volatile: False kde location: /var/db/repos/kde sync-type: git sync-uri: https://github.com/gentoo-mirror/kde.git masters: gentoo eclass-overrides: sam_c volatile: False local location: /var/db/repos/local masters: gentoo eclass-overrides: sam_c volatile: False qt location: /var/db/repos/qt sync-type: git sync-uri: https://github.com/gentoo-mirror/qt.git masters: gentoo eclass-overrides: sam_c volatile: False sam_c location: /var/db/repos/sam_c sync-type: git sync-uri: https://github.com/gentoo-mirror/sam_c.git masters: gentoo eclass-overrides: sam_c volatile: False Binary Repositories: binhost priority: 9999 sync-uri: https://www.mirrorservice.org/sites/distfiles.gentoo.org/releases/amd64/binpackages/23.0/x86-64 Installed sets: @sam-emacs, @sam-fonts, @sam-fortune, @sam-tests ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 -Wstrict-aliasing -Wfree-nonheap-object -Wuninitialized -Wmaybe-uninitialized -Wreturn-type -Wbuiltin-declaration-mismatch -Wtautological-compare" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 -Wstrict-aliasing -Wfree-nonheap-object -Wuninitialized -Wmaybe-uninitialized -Wreturn-type" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg=y --implicit-system-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --jobs=4 --load-average 32" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 " FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg clean-logs config-protect-if-modified distlocks export-pms-vars fixlafiles ipc-sandbox merge-wait mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 " GENTOO_MIRRORS="https://www.mirrorservice.org/sites/distfiles.gentoo.org/ https://mirror.bytemark.co.uk/gentoo/ https://mirrors.soeasyto.com/distfiles.gentoo.org/" LANG="en_GB.UTF-8" LDFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -g1 -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -fdiagnostics-details -fdiagnostics-set-output=text:experimental-nesting=yes -Wa,-O2 -Wa,-mtune=znver2 -Warray-bounds --param=ggc-min-expand=120 -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=odr -Warray-bounds -fdiagnostics-details -Wstringop-overread -Wstringop-overflow -Wstringop-truncation -Wformat-overflow -Wformat-truncation -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -flto=jobserver -Wl,--defsym=__gentoo_check_ldflags__=0" LEX="reflex" LINGUAS="en en_GB" MAKEOPTS="-j32 -l32" PKGDIR="/var/cache/binpkgs" PORTAGE_BUNZIP2_COMMAND="lbunzip2" PORTAGE_COMPRESS="xz" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs" SHELL="/bin/bash" USE="X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr crypt dbus declarative dist-kernel dri dts dvd dvdr editorconfig emacs encode exif f16c filecaps firewalld flac fma3 freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libnotify libtirpc lto mad mmx mmxext mng modules-compress mp3 mp4 mpeg multilib ncurses nftables nls ogg opengl openmp pam pango pclmul pcre pdf pgo pic pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 qt6 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test test-rust tiff truetype udev udisks unicode upower usb valgrind verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gcc_14" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" GUILE_SINGLE_TARGET="3-0" GUILE_TARGETS="3-0" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-2" POSTGRES_TARGETS="postgres17" PYTHON_SINGLE_TARGET="python3_13" PYTHON_TARGETS="python3_13 pypy3 pypy3_11 python3_10 python3_11 python3_12 python3_13t" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa i386 m68k ppc ppc64 ppc64le sparc sparc64 x86_64" RUBY_TARGETS="ruby32 ruby33 ruby34" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account" YACC="byacc" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
The patch was dropped in: commit 381cfa494305a29eed29c54255d4395dbfc66ab0 Author: Filip Kobierski <fkobi@pm.me> Date: Thu Dec 26 20:31:09 2024 +0100 net-p2p/syncthing: add 1.29.5 with improved ebuild changes, from top to bottom: - do not rename distfile - move project primary license to be the first - made RDEPEND more readable - updated DOCS - removed race patch - added loops to shorten the ebuild in src_{prepare,install} - swap $(usex a b "") to $(usev a b) - use brace expansion instead of for loop for installing tools - swap "syncthing" to ${PN} where it makes sense Signed-off-by: Filip Kobierski <fkobi@pm.me> Part-of: https://github.com/gentoo/gentoo/pull/39851 Closes: https://github.com/gentoo/gentoo/pull/39851 Signed-off-by: Marc Schiffbauer <mschiff@gentoo.org> It doesn't say *why*, though (please say that in future -- if you dropped it because it doesn't apply anymore and you don't see why it was there, say that in the commit message). At https://github.com/gentoo/gentoo/pull/39851#issue-2760089746, it says: > @mschiff could you please explain what is the tests_race patch for? > The patch does not apply as upstream changed the build script. > Do we still need it?
FWIW, the patch was added in: commit 258b078422e2aad516119787da45a8c2d8c0aa78 Author: Marek Szuba <marecki@gentoo.org> Date: Wed Mar 8 11:32:23 2023 +0000 net-p2p/syncthing: add 1.23.2, drop 1.23.0 Signed-off-by: Marek Szuba <marecki@gentoo.org> I'm also surprised that neither of you hit it, because it should happen (but maybe it doesn't) with PIE, which we do in: go-module_src_unpack() { if use amd64 || use arm || use arm64 || ( use ppc64 && [[ $(tc-endian) == "little" ]] ) || use s390 || use x86; then GOFLAGS="-buildmode=pie ${GOFLAGS}" fi
Created attachment 927695 [details] build.log.xz
I see that in the build.go "-race" is mentioned twice. Since we target PIE, which conflicts with that flag, maybe it would be better to have a sed 's/-race//g' instead of the patch? > > Do we still need it? I was hoping for an answer before it gets merged. Also Sam, could you please edit the title to contain both flags? Like "${P} fails tests: -buildmode=pie conflicts with -race".
(In reply to Filip Kobierski from comment #4) > I see that in the build.go "-race" is mentioned twice. I'm still curious as to how you can't hit it -- do tests really pass for you? > Since we target PIE, which conflicts with that flag, maybe it would be > better to have a sed 's/-race//g' instead of the patch? It's fine with me as long as people use qa-sed to notice if it stops applying. > > > > Do we still need it? > I was hoping for an answer before it gets merged. I don't blame you ;) > > Also Sam, could you please edit the title to contain both flags? > Like "${P} fails tests: -buildmode=pie conflicts with -race". Sure.
