954254 – sci-physics/yoda-2.1.0: broken --enable-h5

Bug 954254 - sci-physics/yoda-2.1.0: broken --enable-h5

Summary: sci-physics/yoda-2.1.0: broken --enable-h5

Status:	CONFIRMED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	APN-Pucky

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2025-04-23 09:22 UTC by Michał Górny
Modified:	2025-04-23 09:48 UTC (History)
CC List:	2 users (show)

See Also:	https://gitlab.com/hepcedar/yoda/-/merge_requests/325
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2025-04-23 09:22:13 UTC

The ebuild passes:

  --enable-h5

However, configure.ac is a total mess:

  AC_ARG_ENABLE([h5], [AS_HELP_STRING([--disable-h5],[disable H5 extension  @<:@default=build@:>@])], [], [with_h5=yes])
  if test x$with_h5 = xyes; then

So passing --enable-h5 sets $enable_h5 but they actually check for $with_h5.

Comment 1 APN-Pucky 2025-04-23 09:35:50 UTC

Thanks, for pointing this out. Previously they and the ebuild used --with-h5. I don't know why they changed to enable.

I guess the same applies to sci-physics/rivet https://gitlab.com/hepcedar/rivet/-/blob/release-4-1-x/configure.ac?ref_type=heads#L105. I'll make the same MR there as you did there.

Comment 2 Michał Górny archtester

2025-04-23 09:48:21 UTC

Yeah, I've just gotten to rivet and it's the same.  Thanks for taking it from here!