With the update to 3.4.0 htop stops building on prefix. 3.3.0 worked and still works. Error Message: $ ebuild htop-3.4.0.ebuild configure * htop-3.4.0.tar.xz BLAKE2B SHA512 size ;-) ... [ ok ] * checking ebuild checksums ;-) ... [ ok ] * checking auxfile checksums ;-) ... [ ok ] * checking miscfile checksums ;-) ... [ ok ] * Determining the location of the kernel source code * Unable to find kernel sources at /usr/src/linux * Please make sure that /usr/src/linux points at your running kernel, * (or the kernel you wish to build against). * Alternatively, set the KERNEL_DIR environment variable to the kernel sources location * Unable to calculate Linux Kernel version for build, attempting to use running version * Found kernel object directory: * /usr/src/kernels/6.13.6-200.fc41.x86_64 * Found sources for kernel version: * 6.13.6-200.fc41.x86_64 * Checking for suitable kernel configuration options ... [ ok ] >>> Unpacking source... >>> Unpacking htop-3.4.0.tar.xz to /home/share/gentoo/var/tmp/portage/sys-process/htop-3.4.0/work >>> Source unpacked in /home/share/gentoo/var/tmp/portage/sys-process/htop-3.4.0/work >>> Preparing source in /home/share/gentoo/var/tmp/portage/sys-process/htop-3.4.0/work/htop-3.4.0 ... >>> Source prepared. >>> Configuring source in /home/share/gentoo/var/tmp/portage/sys-process/htop-3.4.0/work/htop-3.4.0 ... * econf: updating htop-3.4.0/build-aux/config.guess with /home/share/gentoo/usr/share/gnuconfig/config.guess * econf: updating htop-3.4.0/build-aux/config.sub with /home/share/gentoo/usr/share/gnuconfig/config.sub ./configure --prefix=/home/share/gentoo/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/home/share/gentoo/usr/share/man --infodir=/home/share/gentoo/usr/share/info --datadir=/home/share/gentoo/usr/share --sysconfdir=/home/share/gentoo/etc --localstatedi r=/home/share/gentoo/var/lib --datarootdir=/home/share/gentoo/usr/share --disable-dependency-tracking --disable-silent-rules --docdir=/home/share/gentoo/usr/share/doc/htop-3.4.0 --htmldir=/home/share/gentoo/usr/share/doc/htop-3.4.0/html --libdir=/home/share/gentoo/usr/lib64 --enable-unicode --disable-debug --enable-hwloc --disable-affinity --disable-openvz --enable-unicode --enable-unwind --disable-vserver --enable-capabilities --enable-delayacct --enable-sensors ... checking for netlink/attr.h... no configure: error: can not find required header files netlink/attr.h, netlink/handlers.h, netlink/msg.h The problem is that in `configure.ac` it now uses hardcoded paths to `/usr/include/libnl3` to check whether libnl3 is installed: AC_ARG_ENABLE([delayacct], [AS_HELP_STRING([--enable-delayacct], [enable Linux delay accounting support; requires pkg-config, libnl-3 and libnl-genl-3 @<:@default=check@:>@])], [], [enable_delayacct=check]) case "$enable_delayacct" in no) ... check) ... yes) old_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS -I/usr/include/libnl3" AC_CHECK_HEADERS([netlink/attr.h netlink/handlers.h netlink/msg.h], [], [AC_MSG_ERROR([can not find required header files netlink/attr.h, netlink/handlers.h, netlink/msg.h])]) CFLAGS="$old_CFLAGS" ;; This being prefix, this can easily break. The same is not true for 3.3.0. There it used to use `pkgconfig` to check whether the library is installed: AC_ARG_ENABLE([delayacct], [AS_HELP_STRING([--enable-delayacct], [enable Linux delay accounting support; requires pkg-config, libnl-3 and libnl-genl-3 @<:@default=check@:>@])], [], [enable_delayacct=check]) case "$enable_delayacct" in no) ... check) ... yes) m4_ifdef([PKG_PROG_PKG_CONFIG], [ PKG_PROG_PKG_CONFIG() PKG_CHECK_MODULES(LIBNL3, libnl-3.0, [], [AC_MSG_ERROR([can not find required library libnl3])]) PKG_CHECK_MODULES(LIBNL3GENL, libnl-genl-3.0, [], [AC_MSG_ERROR([can not find required library libnl3genl])]) AM_CFLAGS="$AM_CFLAGS $LIBNL3_CFLAGS $LIBNL3GENL_CFLAGS" LIBS="$LIBS $LIBNL3_LIBS $LIBNL3GENL_LIBS" AC_DEFINE([HAVE_DELAYACCT], [1], [Define if delay accounting support should be enabled.]) For some reason this was remove by upstream. The same seems to be true for the check on `unwind`, which hardcodes `/usr/include/libunwind` as check to whether `libunwind` is installed! This was already the case in 3.3.0 as far as I can see. Reproducible: Always
It changed in https://github.com/htop-dev/htop/commit/24b1513296fd61722166625ad46be1c56a5efc44.
Created attachment 920756 [details, diff] htop-3.4.0-configure.ac-fixup-hard-coded-include-paths-for-EPREFIX.patch Really more a hack than anything else I suspect, but this fixes the build. It inserts `${EPREFIX}` into `configure.ac` at the 5 places I suspect could be useful and then runs `eautoreconf` unconditionally to regenerate the configure script.
The right fix is to use PKG_CHECK_MODULES again ;)
(In reply to Sam James from comment #3) > The right fix is to use PKG_CHECK_MODULES again ;) Filed https://github.com/htop-dev/htop/issues/1639.
(In reply to Sam James from comment #4) > (In reply to Sam James from comment #3) > > The right fix is to use PKG_CHECK_MODULES again ;) > > Filed https://github.com/htop-dev/htop/issues/1639. There's a PR already that I missed! https://github.com/htop-dev/htop/pull/1637
(In reply to Sam James from comment #3) > The right fix is to use PKG_CHECK_MODULES again ;) Fully ack.
