Bug 94739 – xscreensaver-4.21 - 'Same Random Savers' doesn't work

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benjamin Ritcey 2005-06-01 07:44:55 UTC]

Not sure if this is a xscreensaver bug or a problem with the ebuild, but the
'Same Random Savers' mode in xscreensaver-4.21 only shows one hack, with my
other screen blank.  This mode should use the same hack on all screens in a
multi-screen setup.  If we think it's an upstream bug, let me know and I'll try
to go through JWZ.

Reproducible: Always
Steps to Reproduce:
1.  Merge xscreensaver-4.21 with xinerama enabled
2.  Chose 'Same Random Savers'
3.  Activate screensaver 

Actual Results:  
only one hack displayed, on the leftmost screen in my case

Expected Results:  
run the same hack on both screens.

This is with an Nvidia Quadro card, using the TwinView settings.

Portage 2.0.51.22-r1 (default-linux/x86/2005.0, gcc-3.4.3-20050110,
glibc-2.3.5-r0, 2.6.11-gentoo-r8 i686)
=================================================================
System uname: 2.6.11-gentoo-r8 i686 Intel(R) Xeon(TM) CPU 2.40GHz
Gentoo Base System version 1.6.12
ccache version 2.4 [disabled]
dev-lang/python:     2.3.5
sys-apps/sandbox:    1.2.8
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.5
sys-devel/binutils:  2.16-r1
sys-devel/libtool:   1.5.18
virtual/os-headers:  2.6.11-r1
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=i686 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="ftp://gentoo.mirrors.pair.com/ http://gentoo.mirrors.pair.com/
http://mirror.datapipe.net/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://localhost/gentoo-portage"
USE="x86 X acl acpi adns alsa apache2 apm avi berkdb bitmap-fonts cdr crypt cups
curl divx4linux dvd dvdr eds emboss encode esd evo exiscan-acl flac foomaticdb
fortran gd gdbm gif gnome gpm graphviz gstreamer gtk gtk2 gtkhtml guile hal ht
imagemagick imap imlib java jpeg ldap libg++ libwww mad maildir mbox mikmod mmx
mmx2 mono mozilla mp3 mpeg mysql ncurses nptl ogg oggvorbis opengl oss pam pda
pdflib perl png python quicktime readline rrdtool ruby samba sdl slang snmp
speex spell sqlite sse sse2 ssl svga tcpd tiff truetype truetype-fonts
type1-fonts v4l vorbis xinerama xml xml2 xmms xv zlib userland_GNU kernel_linux
elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS

[Comment 1 jason hord 2005-06-07 10:43:02 UTC]

Created attachment 60783 [details, diff]
Patch to fix random-same bug

The 'Same Random' bug appears to be a problem with XScreenSaver.  I have
included a patch that fixed the problem on my system with sources downloaded
directly from jwz.org.	I sent an e-mail to JWZ regarding the problem, but have
not recieved a response.

[Comment 2 Benjamin Ritcey 2005-06-09 07:59:58 UTC]

I can't attach files for some reason, so inline:  patch to the ebuild and a
small patch for the sources (from jason hord's patch, which didn't apply cleanly
for me, for some reason).  This fixes the problem for me.

---------------- xscreensaver-4.21.ebuild.patch --------------

--- xscreensaver-4.21.ebuild    2005-06-09 10:54:33.000000000 -0400
+++ xscreensaver-4.21-r1.ebuild 2005-06-07 14:56:49.000000000 -0400
@@ -87,6 +87,8 @@
        epatch ${FILESDIR}/${PN}-4.21-settings.patch
        # disable not-safe-for-work xscreensavers
        use offensive || epatch ${FILESDIR}/${PN}-4.16-nsfw.patch
+       # fix 'same random' mode
+       epatch ${FILESDIR}/${PN}-4.21-samerandom.patch
 }

 src_compile() {

------------------------ cut here ------------------------------

--------------------- xscreensaver-4.21-samerandom.patch --------
--- driver/subprocs.c.orig      2005-06-09 10:41:13.000000000 -0400
+++ driver/subprocs.c   2005-06-09 10:42:03.000000000 -0400
@@ -775,7 +775,7 @@
          /* Use the same hack that's running on screen 0.
              (Assumes this function was called on screen 0 first.)
            */
-          ssi->current_hack = si->screens[0].current_hack;
+          new_hack = si->screens[0].current_hack;
        }
       else  /* (p->mode == RANDOM_HACKS) */
        {

-------------------------- cut here -----------------------------

[Comment 3 Benjamin Ritcey 2005-06-23 07:19:10 UTC]

FYI, this patch has been incorporated into 4.22

[Comment 4 Octavio Ruiz (Ta^3) 2005-06-23 14:12:46 UTC]

Bug 96894

[Comment 5 Jonathan Smith (RETIRED) 2005-06-23 15:39:55 UTC]

fixed in 5.22