Bug 946880 – dev-perl/Cache-Memcached-Fast filters flto incorrectly resulting in a build failure when LTO is enabled

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description zurabid2016 2024-12-24 14:12:56 UTC]

Created attachment 914819 [details]
The build.log file

There is a patch called Cache-Memcached-Fast-0.270.0-no-flto.patch in FILESDIR that attempts to filter flto out. However, it only removes the '-flto' part, which works most of the times except when flto is specified with a number of jobs: '-flto=16'. With the example value '-flto=16', it leaves '=16', which is, obviously, not a valid compiler flag.

[Comment 1 zurabid2016 2024-12-24 14:28:23 UTC]

By changing the patch's regex to '-flto(=\w*)?\b', the build failure is fixed, but the -flto flag appears here and there. The same effect is observed if filter-lto() function from flag-o-matic.eclass is used

[Comment 2 zurabid2016 2024-12-24 14:35:49 UTC]

Why does LTO even need to be filtered, by the way? The initial patch seems to have been added in 2017, see commit 3a948a110ad8e44beba6a6ae3edf67b8cca66981 "dev-perl/Cache-Memcached-Fast: Bump to version 0.250.0". For me, Cache-Memcached-Fast builds just fine with LTO

[Comment 3 zurabid2016 2024-12-24 14:37:45 UTC]

see https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a948a110ad8e44beba6a6ae3edf67b8cca66981

[Comment 4 zurabid2016 2024-12-24 14:56:47 UTC]

It actually seems as the package adds flto itself

[Comment 5 Sam James 2024-12-24 19:31:03 UTC]

(In reply to zurabid2016 from comment #4)
> It actually seems as the package adds flto itself

We should strip that out too.