Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 94571 - Remove USERLAND autodetection code from portage
Summary: Remove USERLAND autodetection code from portage
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-30 17:56 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-10-10 07:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to remove USERLAND autodetection. (portage-2.0.51.22-noautodetection.patch,1.26 KB, patch)
2005-05-30 17:57 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-30 17:56:41 UTC
Currently portage autodetects the USERLAND of the current system using os's uname to fill it.
That's a non-dependable behaviour and as USERLAND now is set on make.defaults, that code can probably be removed and just use the right USERLAND values.

The attached patch does exactly that, using os.environ["USERLAND"] to set up the rest of vars instead of set that environment var using the ostype.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-30 17:57:21 UTC
Created attachment 60228 [details, diff]
Patch to remove USERLAND autodetection.
Comment 2 SpanKY gentoo-dev 2005-05-30 18:15:34 UTC
why not make it fall back to autodetection if USERLAND is set to "" or unset
Comment 3 Jason Stubbs (RETIRED) gentoo-dev 2005-06-01 07:33:31 UTC
Have you actually tested this patch? os.environ["USERLAND"] will usually raise 
a KeyError for not being defined. The profile stuff never gets into portage's 
environment. It's read in through an instance of the config class that gets 
defined in portage.py *after* portage_data has already been imported. 
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-06-02 07:16:38 UTC
Ok I think I messed up the files when I tested this (just found out that there   
was a .rej with the whole patch in the portage/pym directory of the g/fbsd box  
where I (though of having) tested that, so I just tested that the original 
portage worked. 
  
Sorry about that, I'll work on a working patch asap. 
Comment 5 Jason Stubbs (RETIRED) gentoo-dev 2005-06-06 07:18:52 UTC
Might want to leave this for HEAD. That will have to wait until configuration 
stuff is sorted out though... 
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-10-10 07:48:00 UTC
Scratching this for now, the CHOST expansion will take care.