ebuild for libtorrent 0.6.3 copied ebuild from 0.6.2 and removed the epatch line and changed ./auotgen.sh to ./configure Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 60205 [details] ebuild new ebuild
I needed to update -fbsd patch as that is still needed for malloc check. The other patch is applied and so I just dropped it. Note that ./autogen is still needed anyway.
(In reply to comment #2) > I needed to update -fbsd patch as that is still needed for malloc check. The > other patch is applied and so I just dropped it. > > Note that ./autogen is still needed anyway. Hum, not on my system I ran ./configure and did not need to patch for malloc
The fact that it works on your system doesn't make that patch useless. That is needed for Gentoo/FreeBSD compatibility.
(In reply to comment #4) > The fact that it works on your system doesn't make that patch useless. That is needed for Gentoo/FreeBSD > compatibility. It would be nice if the patch was applied if I was running the fbsd system and not applied if I was not. Or atlest have some type of autodetection when syncing so I wouldn't have patches that do not apply to my system. But just a thought and prob. would be better off if it was mentioned somewhere else.
As I already posted on my blog some time ago, adding patch combinations is something which makes complex finding problems for us. Conditional patching is *not* a way to go. This means that the patch are always applied on all systems without regard if they are just for fbsd or not; also because most of them aren't exactly fbsd specific (just a couple of them really are) and are just generic compatibiltiy.