Bug 94340 – gquilt-0.02.ebuild (New Package)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrew Frink 2005-05-28 18:42:31 UTC]

gquilt is a python/gtk frontend to guilt (http://savannah.nongnu.org/projects/quilt/), an CMD Line patch managment tool.
this ebuild depends on python and pygtk.. no other known deps.

[Comment 1 Andrew Frink 2005-05-28 18:44:31 UTC]

Created attachment 60056 [details]
this is my attempt at an ebuild for gquilt

comments on my ebuild welcome... as this is my first ebuild, thansk all.

[Comment 2 Andrew Frink 2005-05-28 18:48:04 UTC]

Created attachment 60057 [details]
gquilt-0.02.ebuild

my first ebuild... comments welcome

[Comment 3 Andrew Frink 2005-05-28 22:39:45 UTC]

Created attachment 60062 [details]
gquilt-0.02.ebuild(a better one)

[Comment 4 Andrew Frink 2005-05-28 22:41:12 UTC]

Created attachment 60063 [details, diff]
gquilt-destdir.patch

a patch for a bad make file

[Comment 5 Andrew Frink 2005-05-30 22:19:30 UTC]

Created attachment 60239 [details]
gquilt-0.02.ebuild

this ebuild symlinks /usr/lib/gquilt/gquilt.xp to /usr/share/pixmaps/gquilt.xpm
for easier access, from within gnome.

[Comment 6 Andrew Frink 2005-05-30 22:21:28 UTC]

Created attachment 60240 [details, diff]
gquilt-destdir.patch

this patch to Makefile adds support for DESTDIR and adds a name change for the
icon. As well as chaging the PREFIX= line from /usr/local to /usr

[Comment 7 Andrew Frink 2005-05-30 22:22:00 UTC]

Comment on attachment 60239 [details]
gquilt-0.02.ebuild

adds symlinking the icon to /usr/share/pixmaps

[Comment 8 Aaron Walker (RETIRED) 2005-06-20 06:25:59 UTC]

I had already written an ebuild and a Makefile patch before seeing this bug.  I
will give you some tips on improvements your ebuild would've needed before being
accepted:

 - wrong LICENSE.  you can see in gquilt.py it's GPL-2.
 - RESTRICT="nomirror" shouldn't be there as the license does not require it.
 - you assign to DOCS which afaik is really only used by gnome2.eclass (maybe a
few others), which check the value of that variable and run dodoc.  Therefore
your ebuild doesn't actually install the ChangeLog.  Solution: just add a dodoc
statement to src_install.
 - you have an empty src_compile resulting in make not being run until 'make ...
install'.  why specify a src_install at all?  The default src_install will run make.
 - You patched the Makefile so you should've just added an 'install -d
$(DESTDIR)$(PREFIX)/bin', so that the 'dodir /usr/bin' before make install is
unnecessary.

Thanks for the contribution :)

dev-util/gquilt-0.06 is in CVS.

[Comment 9 Aaron Walker (RETIRED) 2005-06-20 06:32:20 UTC]

Also one thing I just noticed.  In the future always use 4 space tabs for ebuilds.