Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943209 - sys-fs/xfsprogs-6.11: installs shared library libhandle.so.1.0.3 but nothing uses it
Summary: sys-fs/xfsprogs-6.11: installs shared library libhandle.so.1.0.3 but nothing ...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2024-11-10 23:16 UTC by Holger Hoffstätte
Modified: 2024-11-11 20:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for xfsprogs-6.11.0 to properly clean up libhandle (cleanup-libhandle.patch,594 bytes, patch)
2024-11-11 18:17 UTC, Holger Hoffstätte
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2024-11-10 23:16:45 UTC
While investigating https://bugs.gentoo.org/943200 I found that xfs_scrub adds "-static" in order to statically link against xfsprogs' own libhandle.
Indeed it turns out that none of the xfsprogs executables dynamically link against the shared lib, which is then installed anyway.

Removing the -static in the Makefile lets it successfully link against the shared lib.

IMHO we should either:
1) continue to link libhandle statically and not install it
2) link dynamically

Since libhandle is only ~18k it's probably not worth the shared trouble and easiest to just not install it.


Reproducible: Always
Comment 1 Holger Hoffstätte 2024-11-11 18:17:11 UTC
Created attachment 908476 [details, diff]
Patch for xfsprogs-6.11.0 to properly clean up libhandle
Comment 2 Holger Hoffstätte 2024-11-11 18:18:44 UTC
It looks there was already half a cleanup in place, so the attached patch just goes all the way. Verified with ldd on all xfsprogs binaries in sbin.
Comment 3 Holger Hoffstätte 2024-11-11 19:00:16 UTC
Btw it also seems the parallel make dependencies are fixed, I successfully built several times with -j8.
Comment 4 Holger Hoffstätte 2024-11-11 20:07:21 UTC
Closing as invalid - I missed the fact that xfsprogs also installs headers, and libhandle is needed in case someone wants to develop their own xfs tooling.
Sorry for the noise.