Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 943116 - www-client/firefox-132.0.1-r1[clang] fails to build with pgo lto "Building firefox with USE=pgo requires LTO!"
Summary: www-client/firefox-132.0.1-r1[clang] fails to build with pgo lto "Building fi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-09 10:29 UTC by David Goudou
Modified: 2024-11-12 00:19 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,1.59 KB, text/x-log)
2024-11-09 10:29 UTC, David Goudou 		Details
emerge --info (emergeinfo.txt,5.94 KB, text/plain)
2024-11-09 10:31 UTC, David Goudou 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Goudou 2024-11-09 10:29:57 UTC 
Created attachment 908184 [details]
build.log

Perhaps related to: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b646e613de013ac94dbfb10146bcb769a759bf3

 * Messages for package www-client/firefox-132.0.1-r1:

 * Building firefox with USE=pgo requires LTO!
 * ERROR: www-client/firefox-132.0.1-r1::gentoo failed (setup phase):
 *   Please fix your CFLAGS/CXXFLAGS.
 * 
 * Call stack:
 *                   ebuild.sh, line 136:  Called pkg_setup
 *   firefox-132.0.1-r1.ebuild, line 475:  Called die
 * The specific snippet of code:
 *   				die "Please fix your CFLAGS/CXXFLAGS."
 *
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-09 10:30:59 UTC 
Please include emerge --info.
Comment 2 David Goudou 2024-11-09 10:31:21 UTC 
Created attachment 908185 [details]
emerge --info

emerge --info
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-09 13:20:29 UTC 
commit bcec88143087b45ba26f219efa76021e5acac391
Author: Matt Jolly <kangie@gentoo.org>
Date:   Sat Nov 9 21:29:09 2024 +1000

    www-client/firefox: LTO Updates

    Force LTO with USE=pgo

    LTO now comes from CFLAGS, meaning that the REQUIRED_USE
    previously enforcing this was removed in favour of
    `eerror`. Instead we will force LTO even if it's not detected
    from CFLAGS if PGO is in use.

    Drop USE=lto on 128 to bring it into line with 132.

    Signed-off-by: Matt Jolly <kangie@gentoo.org>

Not sure if this fixes it.
Comment 4 Anthony Mendez 2024-11-10 08:48:28 UTC 
Tried bcec88143087b45ba26f219efa76021e5acac391 but still getting the same error.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-10 10:47:22 UTC 
commit 6166e0b9c023cd74725e9eb9d742327856fbd315
Author: Matt Jolly <kangie@gentoo.org>
Date:   Sun Nov 10 08:17:28 2024 +1000

    www-client/firefox: update LTO & Rust configuration

    - We don't need to `die` if using GCC and LTO; the linker is set
      to bfd in `src_conifgure`.
    - Set RUST_MIN_VER to 1.77.1 - LLVM_COMPAT 17 could result in
      a Rust slot lower than 1.76 being selected during a GCC build.
    - Be more specific about what is filtered with RUST_NEEDS_LLVM=1.
    - Make 131 consistent with 128 and 132.

    Signed-off-by: Matt Jolly <kangie@gentoo.org>
Comment 6 Anthony Mendez 2024-11-11 23:51:59 UTC 
It seems that 6166e0b9c023cd74725e9eb9d742327856fbd315 fixed it for me! Thanks!
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-12 00:17:59 UTC 
Thanks!