Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 940734 - dev-libs/re2: switch to building with CMake
Summary: dev-libs/re2: switch to building with CMake
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Aliaksei Urbanski
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 940448
  Show dependency tree
 
Reported: 2024-10-03 23:42 UTC by Peter Levine
Modified: 2024-10-07 03:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Levine 2024-10-03 23:42:02 UTC
I'm the proxy maintainer for dev-cpp/gtest.  In trying to support building against an unbundled dev-libs/re2 and dev-cpp/abseil-cpp, but src_configure() fails with:

>  Could not find a package configuration file provided by "re2" with any of
>  the following names:
> 
>    re2Config.cmake
>    re2-config.cmake

Indeed when installing using the Makefile, the pkg-config files get installed but not the CMake files.  On the other hand having tested building with CMake, a CMake build will install both pkg-config and CMake files.
Comment 1 Eli Schwartz gentoo-dev 2024-10-06 22:50:39 UTC
Maybe gtest should try pkg-config as well? The cmake files for re2 don't seem well maintained upstream.
Comment 2 Peter Levine 2024-10-07 01:17:10 UTC
If you look at the git history, it shows Makefile and CMakeLists.txt with the same mtime in May, and that they largely share the same commit history.

From https://github.com/google/re2/wiki/Install:
> Bazel and CMake are also supported. The latter enables generation
> of Visual Studio and Xcode projects as well as Cygwin, MinGW and MSYS
> makefiles. Bug reports and/or fixes are welcome!"
Comment 3 Eli Schwartz gentoo-dev 2024-10-07 02:09:54 UTC
Some fun context :) https://github.com/google/re2/issues/274#issuecomment-683440146

I commented on your linked PR switching to cmake, that I cannot even build the package at all using your ebuild since it fails during cmake_src_configure. And given that junyer doesn't really like cmake it doesn't surprise me that the Makefile gets more actual testing by the developer. I'm not sure mere mtime of the files factors into that.
Comment 4 Peter Levine 2024-10-07 03:48:57 UTC
OK.  Maybe I'll focus on installing re2Config.cmake.in.