940727 – llvm-core/clang-common should not set -D_LIBCPP_HARDENING_MODE, should be done in libcxx

Bug 940727 - llvm-core/clang-common should not set -D_LIBCPP_HARDENING_MODE, should be done in libcxx

Summary: llvm-core/clang-common should not set -D_LIBCPP_HARDENING_MODE, should be don...

Status:	UNCONFIRMED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	LLVM support project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	948159
	Show dependency tree

Reported:	2024-10-03 18:18 UTC by Jannik Glückert
Modified:	2025-01-15 21:19 UTC (History)
CC List:	1 user (show)

See Also:	https://github.com/llvm/llvm-project/pull/109330 https://github.com/llvm/llvm-project/issues/122687
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jannik Glückert 2024-10-03 18:18:52 UTC

see https://github.com/llvm/llvm-project/pull/109330

We should probably switch to setting libc++ hardening when building libc++, via the `-DLIBCXX_HARDENING_MODE=...` cmake option.

This embeds the desired hardening mode into a config header used by libc++.

Comment 1 Sam James archtester

2025-01-15 21:19:38 UTC

The interaction here with https://github.com/llvm/llvm-project/issues/122687 may be interesting.