Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 93860 - [multilib-strict] www-client/mozilla-launcher
Summary: [multilib-strict] www-client/mozilla-launcher
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-24 15:32 UTC by Herbie Hopkins (RETIRED)
Modified: 2005-08-03 07:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Herbie Hopkins (RETIRED) gentoo-dev 2005-05-24 15:32:52 UTC
mozilla-launcher assumes mozilla is installed in /usr/lib/mozilla which is not the case on multilib systems (same goes for firefox et al). This works for now due to the hacky lib -> lib64 symlink but this will be removed at some point. I'm sure there are several ways to fix this:

1/ This simplest way, change the paths in mozilla-laucher at install time using sed. The following in src_install should do the trick:
dosed "s:/usr/lib/:/usr/$(get_libdir)/:" /usr/libexec/mozilla-launcher

2/ Alternatively some fancy function in mozilla-launcher could be used to determine the location at runtime.

Not sure which way you want to go so I'll leave this to the mozilla herd.
Comment 1 Simon Stelling (RETIRED) gentoo-dev 2005-06-19 08:02:52 UTC
Herbie, the first solution is simple, but wrong. The problem is, you don't know
whether the user installed the normal or the -bin pakage, your fix would always
set it to lib64, which would result in a broken -bin. the script needs to be
modified. i probably will take a look at this next week or so
Comment 2 Simon Stelling (RETIRED) gentoo-dev 2005-06-19 08:22:36 UTC
argh, sorry, you were right, i missed second part. i placed a patch in files
which is applied when we use amd64, it sets the paths always to lib64
Comment 3 Herbie Hopkins (RETIRED) gentoo-dev 2005-06-19 10:08:57 UTC
Reopening this since I feel the solution used is less than ideal:

1/ We're not the only arch that uses lib64 so applying this with use amd64 &&
epatch is a bad idea. (why I suggested using get_libdir)

2/ When we do finally get a multilib capable portage it may be possible to
install these apps with ABI=x86 in which case they will be installed in
lib/lib32 instead of lib64.

The other possible solution is to get -launcher to grep the path from the env.d
entries that mozilla and mozilla-firefox install. The only problem I see with
this is that neither thunderbird or sunbird install env.d entries..

Mozilla team: any input?
Comment 4 Aron Griffis (RETIRED) gentoo-dev 2005-06-30 08:14:08 UTC
Yeah, my input is: I'm working on the real solution to this problem. 
>=mozilla-launcher-1.33 honors MOZILLA_LIBDIR which will be set by the launcher
stubs in /usr/bin

So far the only place this has been implemented is
mozilla-thunderbird-1.0.2-r10, which is pmasked because it changes a lot of
other things.  I hope to release it soon and make similar updates to firefox et al.
Comment 5 Herbie Hopkins (RETIRED) gentoo-dev 2005-07-23 10:53:17 UTC
Aron: Thanks for your effort here, it's much appretiated. Unfortunately you seem
to have added a new problem at the same time, with the new plugins setup. We now
have hardcoded lib paths in the nsplugins patch that you apply to
mozilla/firefox/thunderbird and in mozilla-launcher. The patch can easily be
fixed in the relevent ebuilds with a quick sed call before epatch so that's not
so much of a problem. Setting MOZ_PLUGIN_PATH in mozilla-launcher is a little
more problematic. Any chance we can set MOZ_PLUGIN_PATH within our /usr/bin/$PN
stubs instead of in mozilla-launcher (as you now do with MOZILLA_LIBDIR)?
Comment 6 Aron Griffis (RETIRED) gentoo-dev 2005-08-03 07:16:54 UTC
As Herbie suggested, I fixed this initially by setting MOZ_PLUGIN_PATH in the
launcher stub in /usr/bin

More recently I fixed the nsplugins patch so that it (1) works, (2) does
multilib correctly by relying on $(get_libdir) at compile-time, (3) is called
nsplugins-v2.  That solves the problem correctly for the source packages.  The
bin packages still depend on MOZ_PLUGIN_PATH being set in the launcher stub,
which works fine for them.