too long lines were shrinked: [676/919] x86_64-pc-linux-gnu-gcc -Isrc/libnm-crypto/libnm-crypto-null.a.p -Isrc/libnm-crypto -I../NetworkManager-1.48.4/src/libnm-crypto -I. -I../NetworkManager-1.48.4 -Isrc -I../NetworkManager-1.48.4/src -I/usr/include/gio-unix-2.0 -I/usr/lib64/libffi/include -I/usr/include/glib-2.0 -I/usr/lib64/g [677/919] x86_64-pc-linux-gnu-gcc -Isrc/libnm-crypto/libnm-crypto-gnutls.a.p -Isrc/libnm-crypto -I../NetworkManager-1.48.4/src/libnm-crypto -I. -I../NetworkManager-1.48.4 -Isrc -I../NetworkManager-1.48.4/src -I/usr/include/gio-unix-2.0 -I/usr/lib64/libffi/include -I/usr/include/glib-2.0 -I/usr/lib64 [678/919] x86_64-pc-linux-gnu-gcc -Isrc/nmcli/nmcli.p -Isrc/nmcli -I../NetworkManager-1.48.4/src/nmcli -Isrc/libnm-core-public -I../NetworkManager-1.48.4/src/libnm-core-public -Isrc -I../NetworkManager-1.48.4/src -I. -I../NetworkManager-1.48.4 -Isrc/libnm-client-public -I../NetworkManager-1.48.4/src FAILED: src/nmcli/nmcli.p/agent.c.o x86_64-pc-linux-gnu-gcc -Isrc/nmcli/nmcli.p -Isrc/nmcli -I../NetworkManager-1.48.4/src/nmcli -Isrc/libnm-core-public -I../NetworkManager-1.48.4/src/libnm-core-public -Isrc -I../NetworkManager-1.48.4/src -I. -I../NetworkManager-1.48.4 -Isrc/libnm-client-public -I../NetworkManager-1.48.4/src/libnm-cli ../NetworkManager-1.48.4/src/nmcli/agent.c: In function get_secrets_from_user: ../NetworkManager-1.48.4/src/nmcli/agent.c:88:29: error: assignment to int (*)(void) from incompatible pointer type int (*)(const char *, int) [-Wincompatible-pointer-types] 88 | rl_startup_hook = set_deftext; | ^ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 23.0_desktop_gnome_systemd-20240817-145313 UNMASKED: Please re-assign to toolchain@ if you get a test failure in C, C++, or Fortran code which makes no sense. <sys-devel/gcc-15.0.9999:15 The attached etc.portage.tar.xz has all details. ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-15 * clang/llvm (if any): clang version 18.1.8 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/18/bin Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg /usr/lib/llvm/18 18.1.8 Python 3.12.5 Available Ruby profiles: [1] ruby31 (with Rubygems) [2] ruby32 (with Rubygems) [3] ruby33 (with Rubygems) * Available Rust versions: [1] rust-bin-1.80.1 * The following VMs are available for generation-2: 1) Eclipse Temurin JDK 17.0.12_p7 [openjdk-bin-17] *) Eclipse Temurin JDK 21.0.4_p7 [openjdk-bin-21] 3) Eclipse Temurin JDK 8.422_p05 [openjdk-bin-8] Available Java Virtual Machines: [1] openjdk-bin-8 [2] openjdk-bin-17 [3] openjdk-bin-21 system-vm The Glorious Glasgow Haskell Compilation System, version 9.2.8 php cli (if any): go version go1.23.0 linux/amd64 HEAD of ::gentoo commit 3bf85fad694c0f8630e65fe706deb4ea82ffec3a Author: Repository mirror & CI <repomirrorci@gentoo.org> Date: Tue Aug 20 11:04:18 2024 +0000 2024-08-20 11:04:18 UTC emerge -qpvO =net-misc/networkmanager-1.48.4 [ebuild N ] net-misc/networkmanager-1.48.4 USE="bluetooth concheck gtk-doc introspection libedit modemmanager nss policykit ppp systemd tools wext wifi -audit -connection-sharing -debug -dhclient -dhcpcd (-elogind) -gnutls -iptables -iwd -nftables -ofono -ovs -psl -resolvconf (-selinux) -syslog -teamd -test -vala" ABI_X86="(64) -32 (-x32)"
Created attachment 900814 [details] emerge-info.txt
Created attachment 900815 [details] emerge-history.txt
Created attachment 900816 [details] environment
Created attachment 900817 [details] etc.clang.tar.xz
Created attachment 900818 [details] etc.portage.tar.xz
Created attachment 900819 [details] net-misc:networkmanager-1.48.4:20240820-130939.log.xz
Created attachment 900820 [details] qlist-info.txt.xz
Created attachment 900821 [details] temp.tar.xz
Reproducible with GCC-14 (but with USE=libedit specifically).
Can you retry with 1.48.10? Thanks
Created attachment 908743 [details] =net-misc/networkmanager-1.48.10:0::gentoo Reproduces for =net-misc/networkmanager-1.48.10:0::gentoo
Proposed fix inhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2082
*** Bug 936803 has been marked as a duplicate of this bug. ***
https://bugs.gentoo.org/936803#c9 has a got summary about what happened here.
FWIW, until this is fixed upstream, Gentoo could probably simply apply https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2082/diffs?commit_id=3adffef764ab0a0f637d5f0d76580a788a4b4f6c since all our libedit versions have the matching function signature.
FYI I just hit this bug with net-misc/networkmanager-1.48.10-r1 (rebuild, after updating net-dialup/ppp from 2.5.0-r7 to 2.5.1-r1. Funny enough networkmanager was installed before with USE=libedit, but I don't remember if I changed anything on that build or not as a one-time-only-solution. I think not, as I don't remember anything about it. Long story short, the error looks just like the one mentioned here. I then downloaded the libedit patch (wget https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3adffef764ab0a0f637d5f0d76580a788a4b4f6c.patch) and put it into my portage patch directory for the specific networkmanager version (/etc/portage/patches/net-misc/networkmanager-1.48.10-r1), the build log shows that it had been applied successfully. *I still got the same error.* [ebuild R ] net-misc/networkmanager-1.48.10-r1::gentoo USE="bluetooth concheck connection-sharing gtk-doc introspection libedit modemmanager nftables nss ofono (policykit) ppp systemd tools wifi -audit -debug -dhclient -dhcpcd (-elogind) -gnutls -iptables -iwd -ovs -psl -resolvconf (-selinux) -syslog -teamd -test -vala -wext" ABI_X86="(64) -32 (-x32)" 0 KiB My solution for now was USE="-libedit", which made it build successfully. If you want, I can provide the build logs. Just tell me.
(In reply to Andreas Thalhammer from comment #16) > If you want, I can provide the build logs. Just tell me. Yes, please.
Created attachment 917847 [details] emerge --info '=net-misc/networkmanager-1.48.10-r1::gentoo' but with USE=libedit disabled in /etc/portage/package.use for this specific version. This way the build succeeds, while it fails with USE="libedit"...
Created attachment 917848 [details] build log of failing build (without additional patch) I ran this as USE=libedit emerge -1v net-misc/networkmanager because I've added "-libedit" in my /etc/portage/package.use for now.
Created attachment 917849 [details] build log of failing build with patch from mentioned upstream pull request Build also fails with the patch mentioned in comment #12 i.e. the "user patch" is this one: wget https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/3adffef764ab0a0f637d5f0d76580a788a4b4f6c.patch Again, ran as USE=libedit emerge -1v net-misc/networkmanager because I've added "-libedit" in my /etc/portage/package.use for now.
You are seeing something slightly different, but related readline/libedit API and modern C porting: ../NetworkManager-1.48.10/src/nmcli/connections.c: In function ‘nmcli_editor_tab_completion’: ../NetworkManager-1.48.10/src/nmcli/connections.c:6843:64: error: assignment to ‘void (*)(char **, int, int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types] 6843 | rl_completion_display_matches_hook = uuid_display_hook; | ^ ../NetworkManager-1.48.10/src/nmcli/connections.c:6890:60: error: assignment to ‘void (*)(char **, int, int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types] 6890 | rl_completion_display_matches_hook = uuid_display_hook; | ^
Well, I'm no developer, but "incompatible pointer type" and "libedit" sounded like it was the same. When it is not: do you want me to file a separate bug report for this?
