Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 938233 - games-roguelike/angband-4.2.5 installs duplicate SDL2 desktop files
Summary: games-roguelike/angband-4.2.5 installs duplicate SDL2 desktop files
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-20 07:56 UTC by rnddim
Modified: 2024-08-20 14:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rnddim 2024-08-20 07:56:41 UTC
When going to my start menu in KDE after updating angband, I noticed that there were two Angband (SDL2) entries alongside the X11 entry, which was weird. Looking into it, I have now three angband desktop files installed to /usr/share/applications/, angband.desktop, angband-1.desktop, and angband-2.desktop.

From poking around, I've figured out:

* angband.desktop: SDL2 launcher, comes directly from the source tarball's angband-sdl2.desktop . Exec= line is a tiny embedded shell script designed to detect for wayland.

* angband-1.desktop: X11 launcher, generated by the ebuild. Almost identical to the tarball's angband-x11.desktop, but the Comment= line is slightly different.

* angband-2.desktop: SDL2 launcher, generated by the ebuild. Exec= line is just a plain invocation of angband.

It seems the issue is that the tarball's lib/icons/Makefile was changed between 4.2.4 and 4.2.5, and now makes an effort to install one (and only one) desktop file as 'angband.desktop', explaining what I see in /usr/share/applications. It seems a patch would be needed here, either to make the makefile install all relevant desktop files, or to skip them in favor of gentoo's own generated ones. I don't know which would be preferable.

By the way, it's worth noting that the angband-sdl2.desktop file has been changed since 4.2.5 to drop the wayland detection, making it now functionally identical to what the ebuild generates. This was changed in response to a change in SDL, so it seems there's no reason to prefer Angband's own desktop files at the moment.

Reproducible: Always