Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937839 - [guru] x11-misc/ly: *setup.sh scripts need PREFIX handling and introduce dependencies
Summary: [guru] x11-misc/ly: *setup.sh scripts need PREFIX handling and introduce depe...
Status: UNCONFIRMED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michal Vu
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-13 00:22 UTC by Lucio Sauer
Modified: 2024-08-13 15:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lucio Sauer 2024-08-13 00:22:02 UTC
The ebuild installs *setup.sh files into /etc/ly that needs to be fixed to work with prefixed Gentoo environments. It might be enough to use the hprefixify function from the eclass to prepend ${EPREFIX} to the absolute file paths.

Also, these scripts call xrdb and for version 1.0.2 also xmessage.

Reproducible: Always
Comment 1 Michal Vu 2024-08-13 09:23:06 UTC
(In reply to Lucio Sauer from comment #0)
> The ebuild installs *setup.sh files into /etc/ly that needs to be fixed to
> work with prefixed Gentoo environments. It might be enough to use the
> hprefixify function from the eclass to prepend ${EPREFIX} to the absolute
> file paths.
> 
> Also, these scripts call xrdb and for version 1.0.2 also xmessage.
> 
> Reproducible: Always

Hi, just fixed the prefixes of 1.0.2 version and the 9999 live version and added missing dependencies. Both versions should handle prefixes by now and I ran a few compiled sucessfully on my machine, yet more testing should be needed, the changes have been recently committed in the development branch. 

I'll leave this issue open until it's 100% confirmed the issues have been fixed and thoroughly tested. Just bear in mind that Ly's live version of build.zig doesn't offer Ddata_directory option, which can cause issues. We will just have to wait and see now, I will work with the upstream maintainers to fix the issue in case it arises ASAP.

Let me know if those packages work as soon as the new ebuild modifications/fixes get merged, I need as much feedback as I can.

Michal
Comment 2 Lucio Sauer 2024-08-13 14:54:31 UTC
(In reply to Michal Vu from comment #1)
> Hi, just fixed the prefixes of 1.0.2 version and the 9999 live version and
> added missing dependencies. Both versions should handle prefixes by now and
> I ran a few compiled sucessfully on my machine, yet more testing should be
> needed, the changes have been recently committed in the development branch. 
> 
> I'll leave this issue open until it's 100% confirmed the issues have been
> fixed and thoroughly tested.
I don't have a prefix environment right now and this I've got some higher-priority issues to take care of, but I'll come back to you once I've set one up. Please don't expect an answer too soon though :P.

> Let me know if those packages work as soon as the new ebuild
> modifications/fixes get merged, I need as much feedback as I can.
If I'm not mistaken, you need to touch "${RES}/setup.sh" for ly-9999, not "${RES}/xsetup.sh" and "${RES}/wsetup.sh" since the latter two don't exist anymore.
Comment 3 Lucio Sauer 2024-08-13 14:56:51 UTC
Linking the commits that touch on this bug here for completeness sake:
https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=60eed070466bfcfd1222b60e96f8ef7ef7a0d441
https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=09034012fe080a10d6ff6a2c34dfd863e7498f75


This can be automated by adding a `Bug: https://bugs.gentoo.org/NNNN` tag to your commit message.
The supported tags are listed here:
https://www.gentoo.org/glep/glep-0066.html#commit-messages
Comment 4 Michal Vu 2024-08-13 15:01:21 UTC
(In reply to Lucio Sauer from comment #3)
> Linking the commits that touch on this bug here for completeness sake:
> https://gitweb.gentoo.org/repo/proj/guru.git/commit/
> ?h=dev&id=60eed070466bfcfd1222b60e96f8ef7ef7a0d441
> https://gitweb.gentoo.org/repo/proj/guru.git/commit/
> ?h=dev&id=09034012fe080a10d6ff6a2c34dfd863e7498f75
> 
> 
> This can be automated by adding a `Bug: https://bugs.gentoo.org/NNNN` tag to
> your commit message.
> The supported tags are listed here:
> https://www.gentoo.org/glep/glep-0066.html#commit-messages

Thank you, didn't know that. I will do it next time.