Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 937484 - gnome-extra/gnome-commander-1.18.1 fails tests
Summary: gnome-extra/gnome-commander-1.18.1 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Uwe Scholz
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 887697
  Show dependency tree
 
Reported: 2024-08-07 07:26 UTC by Agostino Sarubbo
Modified: 2024-09-20 22:39 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,252.79 KB, text/plain)
2024-08-07 07:26 UTC, Agostino Sarubbo
Details
1-testlog.txt (1-testlog.txt,7.83 KB, text/plain)
2024-08-07 07:26 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-08-07 07:26:55 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gnome-extra/gnome-commander-1.18.1 fails tests.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2024-08-07 07:26:55 UTC
CC'ing also the author of the commit (14384a4ae965803b1b7bcc23a3729c250c4bcd7d)
Comment 2 Agostino Sarubbo gentoo-dev 2024-08-07 07:26:56 UTC
Created attachment 899331 [details]
build.log

build log and emerge --info
Comment 3 Agostino Sarubbo gentoo-dev 2024-08-07 07:26:57 UTC
Created attachment 899332 [details]
1-testlog.txt

1-testlog.txt
Comment 4 Agostino Sarubbo gentoo-dev 2024-08-07 07:26:58 UTC
Error(s) that match a know pattern:


2/9 test_iv_viewerwidget                    FAIL            0.04s   exit status 1
2/9 test_iv_viewerwidget             FAIL            0.04s   exit status 1
3/9 test_iv_inputmodes                      FAIL            0.04s   exit status 1
3/9 test_iv_inputmodes               FAIL            0.04s   exit status 1
4/9 test_iv_textrenderer                    FAIL            0.03s   exit status 1
4/9 test_iv_textrenderer             FAIL            0.03s   exit status 1
5/9 test_iv_viewerwidget_test               FAIL            0.03s   exit status 1
5/9 test_iv_viewerwidget_test        FAIL            0.03s   exit status 1
6/9 test_iv_fileops_test                    FAIL            0.03s   exit status 1
6/9 test_iv_fileops_test             FAIL            0.03s   exit status 1
7/9 test_iv_bm_search_test                  FAIL            0.03s   exit status 1
7/9 test_iv_bm_search_test           FAIL            0.03s   exit status 1
8/9 test_iv_datapresentation_test           FAIL            0.02s   exit status 1
8/9 test_iv_datapresentation_test    FAIL            0.02s   exit status 1
9/9 test_utils_no_dependencies_tests        FAIL            0.02s   exit status 1
9/9 test_utils_no_dependencies_tests FAIL            0.02s   exit status 1
Program appstreamcli found: NO
Program gtk4-update-icon-cache found: NO
Comment 5 Uwe Scholz 2024-08-21 22:05:56 UTC
Hm, I cannot reproduce the failing tests locally when running the following:

FEATURES=test USE=test emerge -j 1 -l 1 -1v gnome-extra/gnome-commander

When I do that I see in the log output:

[...]
>>> Source compiled.
>>> Test phase: gnome-extra/gnome-commander-1.18.1
>>> Completed testing gnome-extra/gnome-commander-1.18.1
[...]

This happens in a graphical terminal and also in a virtual terminal (after hitting Ctrl+Alt+1).

Unfortunately, I cannot find a log output of the tests so I cannot prove that the tests were really running. What do I need to do to find those logs? 

Apart from that, can you, Agostino, try to run a test with

src_test() {
	# tests attempt to connect to X11 and fail when it is set
	# however, they work just fine without X11
	unset DISPLAY

	default
}

in the ebuild? Looking in your build logs it seems as if the tests require a running display which is not found on your build server:

[...]
stderr:
(test-iv-imagerenderer:36): Gtk-WARNING **: 18:46:00.072: cannot open display:
[...]
Comment 6 Uwe Scholz 2024-09-19 21:31:50 UTC
Could you kindly upload the portage debug log of the command

FEATURES=test USE=test -j 1 -l 1 -d gnome-extra/gnome-commander

I wonder why in my case I see in the compile phase in this log:

+ local 'emake_cmd=make -j11 -l4 '
+ local internal_opts=
+ ___eapi_default_src_test_disables_parallel_jobs
+ [[ 8 =~ ^(0|1|2|3|4|4-slot-abi)$ ]]
+ make -j11 -l4 check -n
+ make -j11 -l4 test -n
+ retval=0
+ kill 34

Actually, the ebuild should use meson and not 'make' to run those tests. I don't know why this doesn't work on my box. But the result of using make is, that no unit test is executed and hence the test phase succeeds for me. :-|
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-09-19 21:34:39 UTC
Could you upload the same? That really shouldn't be happening... the environment file too.
Comment 8 Uwe Scholz 2024-09-20 21:29:40 UTC
Fiddled around today and I think I ran into the same issue which occurred here: https://github.com/gentoo/gentoo/pull/8977#issue-335854358

src_test() {
        virtx default
}

did use the make command for executing tests (which indeed did nothing when using meson at the same time), but

src_test() {
        virtx meson_src_test
}

did the trick in the end. The first option above was provided in https://devmanual.gentoo.org/ebuild-writing/functions/src_test/index.html#tests-that-require-x11, that's what I used yesterday to generate mu build log.

Will provide a fix in a minute.
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-09-20 22:39:30 UTC

commit a2ca5c87e6274fa50ced47478a0153e9f2357fb7
Author: Uwe Scholz <u.scholz83@gmx.de>
Date:   Fri Sep 20 23:28:48 2024 +0200

    gnome-extra/gnome-commander: Fix execution of tests

    Signed-off-by: Uwe Scholz <u.scholz83@gmx.de>
    Closes: gentoo#937484
    Closes: https://github.com/gentoo/gentoo/pull/38708
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org