Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 936150 - net-fs/cifs-utils-{7.0,7.0-r1} misuse of use_enable and also installs deprecated keyutils key
Summary: net-fs/cifs-utils-{7.0,7.0-r1} misuse of use_enable and also installs depreca...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-16 10:40 UTC by Bill Prendergast
Modified: 2024-07-20 15:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed cifs-utils-7.0-r2 ebuild (cifs-utils-7.0-r2.ebuild,3.55 KB, application/vnd.gentoo.ebuild)
2024-07-16 10:43 UTC, Bill Prendergast
Details
add USE=acl dep on keyutils (cifs-utils-7.0-r2.ebuild,3.58 KB, application/vnd.gentoo.ebuild)
2024-07-16 11:00 UTC, Bill Prendergast
Details
patch between 7.0-r1 and 7.0-r2 (ebuild.patch,902 bytes, patch)
2024-07-16 11:06 UTC, Bill Prendergast
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Prendergast 2024-07-16 10:40:42 UTC
in src_configure() there is the construct:
  $(use_enable acl cifsacl cifsidmap)

this results in configure being called with:
./configure … --enable-cifsacl=cifsidmap …

however calling ./configure --help we see:
  --enable-cifsidmap      Create cifs.idmap binary [default=yes]
  --enable-cifsacl        Create get/set cifsacl binary [default=yes]

so that construct needs to be split up
  $(use_enable acl cifsacl)
  $(use_enable acl cifsidmap)


from the cifs.upcall man page:
  The keyutils package has also started including a dns_resolver
  handling program as well that is preferred over the one in
  ``cifs.upcall``. If you are using a keyutils version equal to or
  greater than 1.5, you should use ``key.dns_resolver`` to handle the
  ``dns_resolver`` keytype instead of ``cifs.upcall``.  See
  key.dns_resolver(8) for more info.

The only one version of keyutils is in main gentoo: sys-apps/keyutils-1.6.3-r1
so the src_install() construct
  echo 'create dns_resolver * * /usr/sbin/cifs.upcall %k' \
    > "${ED}/etc/request-key.d/cifs.upcall.conf"
should be removed


Reproducible: Always




Given that cifs-utils configure automatically builds cifs.idmap if it finds keyutils and if we don't explicitly disable it; the ebuild has been serendipitously doing what the user would have wanted (provided they had keyutils installed).
Comment 1 Bill Prendergast 2024-07-16 10:43:05 UTC
Created attachment 897784 [details]
proposed cifs-utils-7.0-r2 ebuild
Comment 2 Bill Prendergast 2024-07-16 11:00:38 UTC
Created attachment 897785 [details]
add USE=acl dep on keyutils

cifs mounts with mount option cifsacl require the cifs.idmap upcall binary and cifs.idmap requires keyutils.
Comment 3 Bill Prendergast 2024-07-16 11:06:36 UTC
Created attachment 897786 [details, diff]
patch between 7.0-r1 and 7.0-r2