Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934797 - app-admin/genromfs-0.5.7 calls commands that do not exist: xxd
Summary: app-admin/genromfs-0.5.7 calls commands that do not exist: xxd
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-24 07:01 UTC by Agostino Sarubbo
Modified: 2024-06-24 17:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,67.04 KB, text/plain)
2024-06-24 07:01 UTC, Agostino Sarubbo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-06-24 07:01:54 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/genromfs-0.5.7 calls commands that do not exist.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0018
Comment 1 Agostino Sarubbo gentoo-dev 2024-06-24 07:01:55 UTC 
CC'ing also the author of the commit (70408a41f6d25839157187dafdc3b82e17a6b8eb)
Comment 2 Agostino Sarubbo gentoo-dev 2024-06-24 07:01:56 UTC 
Created attachment 896320 [details]
build.log

build log and emerge --info
Comment 3 Michael Mair-Keimberger (mm1ke) 2024-06-24 17:13:54 UTC 
Hmm, i guess the missing xxd can be fixed with:
BDEPEND="
	test? ( app-editors/vim-core )
"

However, even with xxd installed, all tests fail for me, for example:

1/13 Test image with no files
--- /var/tmp/portage/app-admin/genromfs-0.5.7/work/genromfs-0.5.7/selftest/1.ok	2009-02-15 11:48:15.000000000 +0100
+++ /var/tmp/portage/app-admin/genromfs-0.5.7/work/genromfs-0.5.7/selftest/1.out	2024-06-24 19:00:47.959440148 +0200
@@ -1,9 +1,9 @@
-0000000: 2d72 6f6d 3166 732d 0000 0060 02d9 ccb2  -rom1fs-...`....
-0000010: 454d 5054 5900 0000 0000 0000 0000 0000  EMPTY...........
-0000020: 0000 0049 0000 0020 0000 0000 d1ff ff97  ...I... ........
-0000030: 2e00 0000 0000 0000 0000 0000 0000 0000  ................
-0000040: 0000 0000 0000 0020 0000 0000 d1d1 ffe0  ....... ........
-0000050: 2e2e 0000 0000 0000 0000 0000 0000 0000  ................
-0000060: 0000 0000 0000 0000 0000 0000 0000 0000  ................
+00000000: 2d72 6f6d 3166 732d 0000 0060 02d9 ccb2  -rom1fs-...`....
+00000010: 454d 5054 5900 0000 0000 0000 0000 0000  EMPTY...........
+00000020: 0000 0049 0000 0020 0000 0000 d1ff ff97  ...I... ........
+00000030: 2e00 0000 0000 0000 0000 0000 0000 0000  ................
+00000040: 0000 0000 0000 0020 0000 0000 d1d1 ffe0  ....... ........
+00000050: 2e2e 0000 0000 0000 0000 0000 0000 0000  ................
+00000060: 0000 0000 0000 0000 0000 0000 0000 0000  ................
 *
-00003f0: 0000 0000 0000 0000 0000 0000 0000 0000  ................
+000003f0: 0000 0000 0000 0000 0000 0000 0000 0000  ................


However, it seems like xxd adds an additional `0` to the index of each line. Without that, the output would be the same.
Now I'm wondering what to do here? Adding an additional `0` to the *.ok file would probably fix the tests? Or should we restrict tests all-together?