934360 – toolchain.eclass: likely a minor mistake in zstd option handling

Bug 934360 - toolchain.eclass: likely a minor mistake in zstd option handling

Summary: toolchain.eclass: likely a minor mistake in zstd option handling

Status:	CONFIRMED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal minor (vote)
Assignee:	Gentoo Toolchain Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2024-06-15 10:47 UTC by Rafał Mużyło
Modified:	2024-06-21 22:49 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rafał Mużyło 2024-06-15 10:47:03 UTC

Given this little beauty is gcc emerge log:
'-lmpc -lmpfr -lgmp -rdynamic -ldl  -lz -Lyes/lib -lzstd'

it seems '$(use_with zstd)' should rather be something like '$(use_with zstd zstd /usr)'.

Comment 1 Mike Gilbert gentoo-dev

2024-06-15 14:51:15 UTC

-L/usr/lib would also be incorrect on most 64-bit archs.

Comment 2 Mike Gilbert gentoo-dev

2024-06-15 16:10:30 UTC

It looks like gcc-14 handles this correctly.

What package/version were you building here? Please provide a build log.

Comment 3 Mike Gilbert gentoo-dev

2024-06-15 16:12:44 UTC

Actually, upon further inspection, it looks like we might need to specify --with-zstd-lib for gcc.