Toying with lintool I noticed that a couple of eclass files use mixed styles of indentation. The attached patch tries to address this using whitespaces that are considered legal by lintool, and partially increasing readability.
Created attachment 4824 [details, diff] eclass whitespaces
ill leave this up to each eclass author ... guys: clean up your stuff ? :) if you need, ill do the identing for you (unless you dont want it done ...)
As cat eclass/java.eclass | sed "s/\t/\./g" clearly shows, my indentation is flawless (so says lintool [it special cases to saying "all is okay" on code for which I am the author, obviously]), so I urge all you guys to follow suit and become perfect developers as well. (In case anybody missed the obvious: the above is pure bullcrap. If you _didn't_ laugh the first time, you have what could be referred to as healthy humour.)
karl: check the set_java_env() and install_mozilla_plugin() .. except if you fixed it in the mean time :P Anyhow, I do not see a problem with the ones I did, as they all use tabs to do indenting. For the record, they are: autotools.eclass gcc.eclass libtool.eclass virtualx.eclass
the perl-module and perl-post and commonbox eclasss seem fine to me... they are all tab indented.
Sorry, this is what I did: lintool --show-details /usr/portage/eclass/autotools.eclass|grep -e 'illegal space' -e ' |%' - (W) Has illegal space characters (marked by %): |%%%%%%%%%./configure --prefix=${AUTO_D} \ |%%%%%%%%emake || die "!!! Failed to build automake !!!" |%%%%%%%%make install || die "!!! Failed to install automake !!!" lintool --show-details /usr/portage/eclass/libtool.eclass|grep -e 'illegal space' -e ' |%' - (W) Has illegal space characters (marked by %): |%%%%retval=$? |%%%%if [ "${1}" != "--test" ] && [ "${retval}" -eq 0 ] |%%%%then |%%%%%%%%cp ltmain.sh ltmain.sh.orig |%%%%%%%%sed -e 's:cd `pwd`; $SHELL $0 --mode=relink $libtool_args:cd `pwd`; $SHELL $0 --mode=relink $libtool_args @inst_prefix_dir@:' \ |%%%%%%%%%%%%ltmain.sh.orig > ltmain.sh |%%%%%%%%rm -f ltmain.sh.orig |%%%%fi |%%%%return ${retval}
Mine probably have problems along this line since I use stuff like mcedit which isn't nice on tabs at all. Will fix...
I've fixed all of mine eclasses.
