Upgraded to xfce4-power-manager-4.19.3 from 4.19.2 and the system tray icon no longer launches upon startup. It can be launched via xfce4-power-manager -c (or xfce4-power-manager-settings) and toggling off and back on again, but it will not launch on next login. Have tried on multiple machines and with multiple icon packs to no avail. I looked at the ebuild and noted many dependency upgrades but have not chased them down individually to see what may have been the culprit. I run Xmonad WM and use trayer for a system tray (Qtile as backup has same issue). Kernel 6.9.3-gentoo. Downgrading to 4.19.2 fixes the "issue". I am not seeing any "errors" in the logs to reference even while running in debug mode, nor have I seen it reported upstream as an issue.
Can you file a bug upstream at https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues ? I just did this afternoon and it was fixed yesterday. :) Briefly looked into commits but didn't see anything re. the tray icon.
(In reply to Holger Hoffstätte from comment #1) > Can you file a bug upstream at > https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues ? I just did this > afternoon and it was fixed yesterday. :) > > Briefly looked into commits but didn't see anything re. the tray icon. I went ahead and filed a bug upstream for this. I scoured the internet for this issue prior to opening the bug here, but it is a brand new release, and I didn't see anything. I know this issue has come up in the past, a few times, but haven't seen the issue in awhile. Issue #234. Because I'm not running XFCE as a desktop, hopefully they will look into it. I know others use xfce4-power-manager with their WMs.
This has been addressed upstream (very fastly) and closed: https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/234 Via commit: https://gitlab.xfce.org/xfce/xfce4-power-manager/-/commit/6d2f8265c58974b31a10ef060e72c30233a19f39 It looks like it will be resolved in version 4.19.4. Keep open until then or should I mark resolved?
Do you need me to backport it or can you wait? Same for Holger.
(In reply to Michał Górny from comment #4) > Do you need me to backport it or can you wait? > > Same for Holger. Thank you for asking. I personally don't need this since I don't use the tray icon and can wait for the next release, but e.g. for laptop users the fix for https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/233 is much more important. So if you want to add patches to fix the most urgent regressions, those would be (in order): 01571e513d7be36be93b1d99be9059786788275e (#233, tested by me) 612c9d03e7e8c605161f1f801f894516352e1c16 (#233 add-on) 6d2f8265c58974b31a10ef060e72c30233a19f39 (#234) Should all apply without problem.
(In reply to Michał Górny from comment #4) > Do you need me to backport it or can you wait? > > Same for Holger. I personally can wait for 4.19.4 so no issue for me. I masked 4.19.3 so it will take care of itself eventually. Glad to test if necessary. Thanks all.
Created attachment 895381 [details] build log
For testing purposes, applied first two patches: 01571e513d7be36be93b1d99be9059786788275e 612c9d03e7e8c605161f1f801f894516352e1c16 No issues compiling and installing. This patch applies successfully but is failing to compile: 6d2f8265c58974b31a10ef060e72c30233a19f39 Attached build log. I applied and merged in succession to isolate which is causing error. Not a dev so not exactly sure if this is an issue on my end or a code issue. It looks like a code issue.
(In reply to Weezer from comment #8) > For testing purposes, applied first two patches: > > 01571e513d7be36be93b1d99be9059786788275e > 612c9d03e7e8c605161f1f801f894516352e1c16 > > No issues compiling and installing. > > This patch applies successfully but is failing to compile: > 6d2f8265c58974b31a10ef060e72c30233a19f39 > > Attached build log. > > I applied and merged in succession to isolate which is causing error. > > Not a dev so not exactly sure if this is an issue on my end or a code issue. > It looks like a code issue. Same here, can reproduce. Strangely enough this error only happens when the patch is applied before configure; it builds fine when configure is run first. Probably best to just leave it alone for now.
(In reply to Holger Hoffstätte from comment #9) > Same here, can reproduce. Strangely enough this error only happens when the > patch is applied before configure; it builds fine when configure is run > first. The reason is that common/xfpm-enum-types.c is autogenerated and somehow that still needs to be fixed up.
(In reply to Holger Hoffstätte from comment #10) > (In reply to Holger Hoffstätte from comment #9) > > Same here, can reproduce. Strangely enough this error only happens when the > > patch is applied before configure; it builds fine when configure is run > > first. > > The reason is that common/xfpm-enum-types.c is autogenerated and somehow > that still needs to be fixed up. I reported this upstream just for information and he suggested that we need to: "You should --enable-maintainer-mode to regenerate xfpm-enum-types.[ch]." Those guys don't mess around with getting back to you! (appreciated but hate to bother them) It looks like that needs to be passed during the compile process, which I'm not sure how that would be handled using the ebuild. Just messing around at this point but glad to see you had the same issue, thanks for testing!
(In reply to Weezer from comment #11) > (In reply to Holger Hoffstätte from comment #10) > > (In reply to Holger Hoffstätte from comment #9) > > > Same here, can reproduce. Strangely enough this error only happens when the > > > patch is applied before configure; it builds fine when configure is run > > > first. > > > > The reason is that common/xfpm-enum-types.c is autogenerated and somehow > > that still needs to be fixed up. > > I reported this upstream just for information and he suggested that we need > to: > > "You should --enable-maintainer-mode to regenerate xfpm-enum-types.[ch]." This breaks the regular build because of course it does. Luckily I'm not known for taking prisoners, so here's a working ebuild: https://github.com/hhoffstaette/portage/tree/master/xfce-base/xfce4-power-manager I should probably feel bad about this because it's obviously terrible, but here we are.
(In reply to Holger Hoffstätte from comment #12) > (In reply to Weezer from comment #11) > > (In reply to Holger Hoffstätte from comment #10) > > > (In reply to Holger Hoffstätte from comment #9) > > > > Same here, can reproduce. Strangely enough this error only happens when the > > > > patch is applied before configure; it builds fine when configure is run > > > > first. > > > > > > The reason is that common/xfpm-enum-types.c is autogenerated and somehow > > > that still needs to be fixed up. > > > > I reported this upstream just for information and he suggested that we need > > to: > > > > "You should --enable-maintainer-mode to regenerate xfpm-enum-types.[ch]." > > This breaks the regular build because of course it does. > Luckily I'm not known for taking prisoners, so here's a working ebuild: > https://github.com/hhoffstaette/portage/tree/master/xfce-base/xfce4-power- > manager > > I should probably feel bad about this because it's obviously terrible, > but here we are. Kudos to you sir! Cloned your repo and stole the ebuild for my local repo. Seems to have worked like a charm! Tested on one machine and will test on another later but I'm sure it will work, just don't feel like it now as brain has been all over the place and needs a break ;) I haven't studied what you did yet, either, but will later. I, like you, would have kept going until I figured it out, but can relax a bit now... Not sure if this issue should be closed/confirmed or left open but I'll leave that up to folks to determine how that goes... Thanks much and HAGD!
Had to look.. I see: # regenerate xfpm-enum-types econf --enable-maintainer-mode "${myconf[@]}" cd common && make xfpm-enum-types.c && cd .. Nice work! That would have taken me a bit to chase down (In reply to Holger Hoffstätte from comment #12) > (In reply to Weezer from comment #11) > > (In reply to Holger Hoffstätte from comment #10) > > > (In reply to Holger Hoffstätte from comment #9) > > > > Same here, can reproduce. Strangely enough this error only happens when the > > > > patch is applied before configure; it builds fine when configure is run > > > > first. > > > > > > The reason is that common/xfpm-enum-types.c is autogenerated and somehow > > > that still needs to be fixed up. > > > > I reported this upstream just for information and he suggested that we need > > to: > > > > "You should --enable-maintainer-mode to regenerate xfpm-enum-types.[ch]." > > This breaks the regular build because of course it does. > Luckily I'm not known for taking prisoners, so here's a working ebuild: > https://github.com/hhoffstaette/portage/tree/master/xfce-base/xfce4-power- > manager > > I should probably feel bad about this because it's obviously terrible, > but here we are. Had to look.. I see: # regenerate xfpm-enum-types econf --enable-maintainer-mode "${myconf[@]}" cd common && make xfpm-enum-types.c && cd .. Nicely done! That bit would have taken me a bit of research to chase down. Thx again.
Michał just pmasked xfce-4.19.* (see https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d47ab351dad5bf503de7d51c3df265e1d715241) so I'd say you can resolve this as WONTFIX.
(In reply to Holger Hoffstätte from comment #15) > Michał just pmasked xfce-4.19.* (see > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=4d47ab351dad5bf503de7d51c3df265e1d715241) so I'd say you can resolve > this as WONTFIX. Interesting, well we got a couple issues "fixed" anyway. Two quick questions: I borked up my last comment and can't edit to fix the duplicate comment, is it even possible? This is my second bug ever reported and have no idea how to do the 'WONTFIX' closing.... I have unconfirmed and resolved. Apologies for my ignorance.
Figured out the WONTFIX option..
