Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933237 - net-news/rssguard: Please add USE="debug" and CMAKE_BUILD_TYPE into ebuild
Summary: net-news/rssguard: Please add USE="debug" and CMAKE_BUILD_TYPE into ebuild
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-31 07:29 UTC by Petr Šourek
Modified: 2024-06-02 18:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rssguard-4.7.2.ebuild (rssguard-4.7.2.ebuild,2.44 KB, text/plain)
2024-05-31 07:48 UTC, Petr Šourek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Šourek 2024-05-31 07:29:59 UTC
Hello,

I had upgraded RSSGuard to newest version 4.7.1 and I got [bug](https://github.com/martinrotter/rssguard/issues/1427), where the feeds were doubled. I had filed it and it seems, that the RSSGuard now builds in Debug mode, since it was removed from CMakeLists.txt.

Can please somebody change the options in ebuild:
	local mycmakeargs=(
		-DBUILD_WITH_QT6=$(usex qt6)
		-DNO_LITE=$(usex webengine)
		-DREVISION_FROM_GIT=OFF
		-DNO_UPDATE_CHECK=ON
		-DENABLE_COMPRESSED_SITEMAP=ON
		-DENABLE_MEDIAPLAYER_QTMULTIMEDIA=$(usex qtmultimedia)
		-DENABLE_MEDIAPLAYER_LIBMPV=$(usex libmpv)
		# recommended
		-DMEDIAPLAYER_FORCE_OPENGL=ON
	)

To:
	local mycmakeargs=(
		-DBUILD_WITH_QT6=$(usex qt6)
		-DNO_LITE=$(usex webengine)
		-DREVISION_FROM_GIT=OFF
		-DNO_UPDATE_CHECK=ON
		-DENABLE_COMPRESSED_SITEMAP=ON
		-DENABLE_MEDIAPLAYER_QTMULTIMEDIA=$(usex qtmultimedia)
		-DENABLE_MEDIAPLAYER_LIBMPV=$(usex libmpv)
		# recommended
		-DMEDIAPLAYER_FORCE_OPENGL=ON
                -DCMAKE_BUILD_TYPE="Release"
	)

Or maybee it would be better to change the ebuild to add debug into USE flags and then based on this flag to fill CMAKE_BUILD_TYPE to "Release" / "Debug".

I am sorry I would do it my self, but my ebuild-fu and git-fu is not strong enough to make good commit.

Thanks,
Regards,
Petr Sourek
Comment 1 Petr Šourek 2024-05-31 07:32:48 UTC
Damn, I forgot to add configuration building info:

>>> Unpacking source...
>>> Unpacking rssguard-4.7.2.gh.tar.gz to /var/tmp/portage/net-news/rssguard-4.7.2/work
>>> Source unpacked in /var/tmp/portage/net-news/rssguard-4.7.2/work
>>> Preparing source in /var/tmp/portage/net-news/rssguard-4.7.2/work/rssguard-4.7.2 ...
> * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/net-news/rssguard-4.7.2/work/rssguard-4.7.2"
> * Build directory  (BUILD_DIR):     "/var/tmp/portage/net-news/rssguard-4.7.2/work/rssguard-4.7.2_build"
> * 
> * Hardcoded definition(s) removed in CMakeLists.txt:
> *    set(CMAKE_BUILD_TYPE "Release")
>>> Source prepared.
Comment 2 Petr Šourek 2024-05-31 07:48:22 UTC
Created attachment 894700 [details]
rssguard-4.7.2.ebuild

Sorry for spam, tried to add it myself, please see attached ebuild for version 4.7.2, where the bug in debug mode is fixed. I am building this ebuild right now and it seems to work.

Only thing, that confuses me is yellow -debug% flag, but I will try to study it later.

[ebuild     U  ] net-news/rssguard-4.7.2::dj [4.7.1::gentoo] USE="qt6 qtmultimedia sqlite webengine -debug% -libmpv -mysql" 0 KiB