Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933109 - dev-libs/libxmlb: python_check_deps checks for setuptools but the ebuild doesn't properly depend on it
Summary: dev-libs/libxmlb: python_check_deps checks for setuptools but the ebuild does...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-29 07:19 UTC by Joonas Niilola
Modified: 2024-10-24 10:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2024-05-29 07:19:44 UTC
Hey,

libxmlb has this check:

python_check_deps() {
	python_has_version -b "dev-python/setuptools[${PYTHON_USEDEP}]"
}

but setuptools is only a dependency with "introspection" use flag:

BDEPEND="
	${PYTHON_DEPS}
	introspection? (
		$(python_gen_any_dep 'dev-python/setuptools[${PYTHON_USEDEP}]')
	)
"

causing a situation where setuptools may not be installed at all, but the ebuild still checks for it.

 * Checking whether python3_12 is suitable ...
 *   dev-lang/python:3.12 ...
 [ ok ]
 *   python_check_deps ...
 *     dev-python/setuptools[python_targets_python3_12(-)] ...
 [ !! ]
 [ !! ]
...
...
...
 * No Python implementation found for the build. This is usually
 * a bug in the ebuild. Please report it to bugs.gentoo.org
 * along with the build log.

 * ERROR: dev-libs/libxmlb-0.3.14::gentoo failed (setup phase):
 *   No supported Python implementation installed.
Comment 1 Andrés Becerra Sandoval 2024-10-22 12:15:45 UTC
Forcing USE="introspection" allows merging the library
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-24 10:18:43 UTC
commit 4c858a2a78c61667d7eb323b21ebf6c91f5c0bd9
Author: Sam James <sam@gentoo.org>
Date:   Tue Oct 22 08:32:37 2024 +0100

    dev-libs/libxmlb: fix python_check_deps

    We don't need setuptools unless USE=introspection, match the dep.

    Signed-off-by: Sam James <sam@gentoo.org>

and then

commit 2aa5dc44303090a50cde94e7afac9a9cda90d68f
Author: Sam James <sam@gentoo.org>
Date:   Tue Oct 22 09:03:59 2024 +0100

    dev-libs/libxmlb: fix python_check_deps

    Bug: https://bugs.gentoo.org/941965
    Fixes: 4c858a2a78c61667d7eb323b21ebf6c91f5c0bd9
    Signed-off-by: Sam James <sam@gentoo.org>

commit 258c82816692c80adf9a3cac7cfedc49931bd3f5
Author: Sam James <sam@gentoo.org>
Date:   Tue Oct 22 09:11:50 2024 +0100

    dev-libs/libxmlb: fix python_check_deps again

    Thanks to Ionen for pointing out this will (obviously) return 0
    unconditionally...

    Bug: https://bugs.gentoo.org/941965
    Signed-off-by: Sam James <sam@gentoo.org>