Please also remove those old fpc and lazarus bugs noone works on anymore - they are not needed but make life harder, since there are hundrets of dead worthless bugs filling up search results in gentoos bugzilla. Reproducible: Always Steps to Reproduce:
Created attachment 59311 [details] fpc-2.0.0.ebuild
Created attachment 59312 [details] fpc-source-2.0.0.ebuild
fpc-ide will be updated upon request or when i'm idle.
fpc-2.0.0.ebuild and fpc-source-2.0.0.ebuild are in portage now. They are quite different from what you posted here, so please take note of my changes for your next submission. Also if you find any problems I introduced, please let me know. http://www.gentoo.org/cgi-bin/viewcvs.cgi/dev-lang/fpc/fpc-2.0.0.ebuild?rev=1.1&content-type=text/vnd.viewcvs-markup http://www.gentoo.org/cgi-bin/viewcvs.cgi/dev-lang/fpc-source/fpc-source-2.0.0.ebuild?rev=1.1&content-type=text/vnd.viewcvs-markup
Thanks for cleaning it up, in the first place. By reading through it, i saw the following things: compiler ebuild: "set_compiler new" has to be "set_pp new" until you rename the function (which might be a nice idea) also - i wonder where you got the image variable from in "pkg_preinst" i cannot find it inside of the ebuild, or in some of the docs why not leave it to "{D}"? in "src_install()" i see no reason for not using emake anymore? but remember to use -j1 then... source ebuild: I had a typo you copied: "# Needed to release candidates etc." has to be "# Needed for release candidates etc." And, why did you take you this single "pkg_preinst"-command completely? I think it should be somewhere else at least...
(In reply to comment #5) > "set_compiler new" has to be > "set_pp new" until you rename the function (which might be a nice idea) Thanks, I fixed the calls to be set_pp. > also - i wonder where you got the image variable from in "pkg_preinst" > i cannot find it inside of the ebuild, or in some of the docs why not leave it > to "{D}"? I don't know why IMAGE is undocumented. It's the correct variable to use for the pkg_* functions. From ebuild(5): D = "${PORTAGE_TMPDIR}/portage/${PF}/image" Contains the path to the temporary install directory. Every write opera- tion that does not involve the helper tools and functions (found below) should be prefixed with ${D}. Do not modify this variable. This will not be available inside of the pkg_* functions. > in "src_install()" i see no reason for not using emake anymore? but remember to > use -j1 then... emake is never appropriate for src_install. It is for building only. See other ebuilds for an example. > source ebuild: > I had a typo you copied: "# Needed to release candidates etc." has to be > "# Needed for release candidates etc." Thanks, fixed. > And, why did you take you this single "pkg_preinst"-command completely? I think > it should be somewhere else at least... Because it wasn't doing anything, from what I could see in the unpacked source. There's no reason to have functions/commands in ebuilds that aren't doing anything. We can revive it if a future release of fpc-source needs it.
Okay. Thank you for explaining it, this clarified things for me :-)
