Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 930846 - sys-kernel/git-sources - patch is different when downloaded from https://git.kernel.org instead of gentoo distfiles mirrors
Summary: sys-kernel/git-sources - patch is different when downloaded from https://git....
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mike Pagano
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-28 23:47 UTC by jospezial
Modified: 2024-05-03 16:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2024-04-28 23:47:11 UTC
I locally bumped to git-sources-6.9_rc6.ebuild before it was bumped in gentoo.
If the patch is not on the gentoo distfiles mirrors then it is downloaded from:

>>> Downloading 'https://git.kernel.org/torvalds/p/v6.9-rc6/v6.8'
--2024-04-29 01:16:46--  https://git.kernel.org/torvalds/p/v6.9-rc6/v6.8
Resolving git.kernel.org (git.kernel.org)... 145.40.68.75, 2604:1380:4601:e00::1
Connecting to git.kernel.org (git.kernel.org)|145.40.68.75|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/rawdiff/?id=v6.9-rc6&id2=v6.8 [following]
--2024-04-29 01:16:46--  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/rawdiff/?id=v6.9-rc6&id2=v6.8
Reusing existing connection to git.kernel.org:443.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: ‘/var/cache/distfiles/patch-6.9-rc6.patch.__download__’

/var/cache/distfiles/patch-6.9-rc6.patch.__download__                         [                                                         <=>                                                                                                                       ]  52,79M  6,37MB/s    in 12s     

2024-04-29 01:17:03 (4,49 MB/s) - ‘/var/cache/distfiles/patch-6.9-rc6.patch.__download__’ saved [55355970]

Later it was bumped in gentoo with:
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-kernel/git-sources/Manifest
has
DIST patch-6.9-rc6.patch 55332584

I then synced and deleted the patch from my distfiles folder.

When the patch is not yet on gentoo distfiles mirrors that causes
!!! Fetched file: patch-6.9-rc6.patch VERIFY FAILED!
!!! Reason: Filesize does not match recorded size
!!! Got:      55355970
!!! Expected: 55332584
Refetching... File renamed to '/var/cache/distfiles/patch-6.9-rc6.patch._checksum_failure_._t5yikrk'

!!! Couldn't download 'patch-6.9-rc6.patch'. Aborting.

Of course it later works when the patch has arrived on gentoo distfiles mirrors.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-04-28 23:48:23 UTC
It would be interesting if you could give us a copy of the one you had before, so we can diff them. I wonder what changed..
Comment 2 jospezial 2024-04-29 00:17:19 UTC
I manually downloaded now https://gentoo.osuosl.org/distfiles/de/patch-6.9-rc6.patch (https://distfiles.gentoo.org/distfiles/de/patch-6.9-rc6.patch)

--- /var/cache/distfiles/patch-6.9-rc6.patch._checksum_failure_._t5yikrk        2024-04-29 01:16:46.000000000 +0200
+++ /home/joerg/Downloads/patch-6.9-rc6.patch   2024-04-29 02:01:59.811895206 +0200
@@ -1,5 +1,5 @@
 diff --git a/.get_maintainer.ignore b/.get_maintainer.ignore
-index c298bab3d3207f..7d1b30aae87426 100644
+index c298bab3d3207..7d1b30aae8742 100644
...

It is the count of checksum that differs through the hole patch.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-04-29 15:41:34 UTC
I think git uses the fewer chars needed to unambigously refer to it. It would be nice if there's some way to ask it to give the full commit hash. I think there is but I don't remember the parameter name..
Comment 4 Mike Pagano gentoo-dev 2024-04-29 22:14:33 UTC
I don't see how this can be correct.

I bump the same way you do.  And of course, the patch is not on distfiles when I do the bump.
Comment 5 Mike Pagano gentoo-dev 2024-05-03 16:21:30 UTC
This does not seem like something I can fix for you. I bump the same way you describe for years and years.  I suggest you wait until the ebuild comes from the official tree or create a git package in a local repo.