https://gitweb.gentoo.org/repo/gentoo.git/commit/app-shells/bash?id=1d98516e65fb3dc0f1e0effc851216e1b827b9d4 Just two minor things I saw here: 1) `$(test-flags-CC -fprofile-partial-training)` is unecessarily called when pgo USE flag is not enabled. 2) Addition of -fprofile-update=atomic is undocumented. In general I think the code shouldn't have been simplified to no two separate conditional blocks. The use of two variables was ok but the pgo logic should have stayed encapsulated, along with the two variables.
(In reply to konsolebox from comment #0) > https://gitweb.gentoo.org/repo/gentoo.git/commit/app-shells/ > bash?id=1d98516e65fb3dc0f1e0effc851216e1b827b9d4 > > Just two minor things I saw here: > > 1) `$(test-flags-CC -fprofile-partial-training)` is unecessarily called when > pgo USE flag is not enabled. meh. > 2) Addition of -fprofile-update=atomic is undocumented. > It's done to avoid multiple processes using bash clobbering it, or for threaded applications, I can't remember which. Not really sure it's a problem, is it? > In general I think the code shouldn't have been simplified to no two > separate conditional blocks. The use of two variables was ok but the pgo > logic should have stayed encapsulated, along with the two variables. I guess? I would review a patch but not really sure this is worth filing a bug other otherwise.
(In reply to Sam James from comment #1) > I would review a patch but not really sure this is worth filing a bug other > otherwise. I thought about giving an example code which I know later would be asked to be in a form of a patch but it's not worth the commit requirements. Indeed these are just minor things but still I think it was worth informing and being "documented" in a form of this post. I'll never know what devs would decide about it.
OK.
