Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927356 - media-gfx/wings-2.3: version bump
Summary: media-gfx/wings-2.3: version bump
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-20 14:50 UTC by John L. Poole
Modified: 2024-07-06 20:05 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (build.log,86.56 KB, text/x-log)
2024-03-20 14:50 UTC, John L. Poole
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John L. Poole 2024-03-20 14:50:13 UTC
I wanted to try the current high watermark, 2.3, or wings.  There is contained in the Makefile for the wings project two (2) git clone statements to dependency projects:
 https://github.com/tonyrog/cl.git and https://github.com/dgud/libigl.git

Gentoo's sandbox which prevents lower level fetches causes the git clones to fail.  Reference:  https://devmanual.gentoo.org/general-concepts/sandbox/index.html

Otherwise, I was able to stage the project and successfully compile it on my own by adding dev-util/rebar.
  
Installing wings is not critical for me (as I can do so outside of portage), but I thought I would document what lies ahead for whoever takes up the maintenance of this package, if at all. 

Reproducible: Always

Steps to Reproduce:
1. emerge media-gfx/wings-2.3

Actual Results:  
make[1]: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3'
git -c advice.detachedHead=false clone --depth 1 -b 3.3.7 https://github.com/eigenteam/eigen-git-mirror.git _deps/eigen
Cloning into '_deps/eigen'...
fatal: unable to access 'https://github.com/eigenteam/eigen-git-mirror.git/': Could not resolve host: github.com
make[1]: *** [Makefile:150: _deps/eigen] Error 128
make[1]: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3'
make[3]: Nothing to be done for 'common'.
make[1]: *** Waiting for unfinished jobs....
make[1]: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3'
git -c advice.detachedHead=false clone --depth 1 -b master https://github.com/dgud/libigl.git _deps/libigl
Cloning into '_deps/libigl'...
fatal: unable to access 'https://github.com/dgud/libigl.git/': Could not resolve host: github.com
make[1]: *** [Makefile:144: _deps/libigl] Error 128
make[1]: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3'
make: *** [Makefile:27: opt] Error 2
 [31;01m*[0m ERROR: media-gfx/wings-2.3::local failed (compile phase):
 [31;01m*[0m   emake failed

Expected Results:  
successful build.

Here are the relevent lines from the Makefile[1]:

jlpoole@ryzdesk /usr/local/src/wings $ cat -n Makefile |grep clone
128  GIT_FLAGS = -c advice.detachedHead=false clone --depth 1
jlpoole@ryzdesk /usr/local/src/wings $ cat -n Makefile |grep git
89          git archive --format=tar \
119  CL_REPO = https://github.com/tonyrog/cl.git
120  IGL_REPO = https://github.com/dgud/libigl.git
121  EIGEN_REPO = https://github.com/eigenteam/eigen-git-mirror.git
138          git $(GIT_FLAGS) -b $(CL_VER) $(CL_REPO) _deps/cl
144          git $(GIT_FLAGS) -b $(IGL_VER) $(IGL_REPO) _deps/libigl
150          git $(GIT_FLAGS) -b $(EIGEN_VER) $(EIGEN_REPO) _deps/eigen
jlpoole@ryzdesk /usr/local/src/wings $

Here's my custom ebuild diff:

ryzdesk /var/db/repos/local/media-gfx/wings # diff wings-2.2.6.1.ebuild wings-2.3.ebuild
14c14,21
<
---
> #
> # 3/16/24 jlpoole: rebar3 per Unix build  instructions
> # added sci-libs/libigl because that package is a dependency
> # on something wings brings in and the command it "git clone"
> # which fails for lack of authentication. So we'll bring th
> # package in the Gentoo way so there should not be a need
> # for installing a dependency.
> #
20a28,29
>         >=dev-util/rebar-3
>
23a33
>       sci-libs/libigl
ryzdesk /var/db/repos/local/media-gfx/wings #
Comment 1 John L. Poole 2024-03-20 14:50:58 UTC
Created attachment 888002 [details]
Build log
Comment 2 Mike Gilbert gentoo-dev 2024-03-21 13:25:31 UTC
ebuilds must not fetch sources themselves unless PROPERTIES="live" is set
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-22 08:46:03 UTC
(In reply to Mike Gilbert from comment #2)
> ebuilds must not fetch sources themselves unless PROPERTIES="live" is set

I don't think it's INVALID as a bug? It's a heads-up for a bump which ahsn't happened yet.
Comment 4 John L. Poole 2024-03-22 10:59:34 UTC
(In reply to Sam James from comment #3)
> (In reply to Mike Gilbert from comment #2)
> > ebuilds must not fetch sources themselves unless PROPERTIES="live" is set
> 
> I don't think it's INVALID as a bug? It's a heads-up for a bump which ahsn't
> happened yet.

Sam is correct.  Although there currently is not a maintainer, I just wanted to lay the groundwork in Bug to help whomever might assume the role.  Probably, the upstream owner should be contacted and persuaded not to pull in other repositories in his Makefile.  Thanks Sam.
Comment 5 benoit.dufour 2024-03-28 23:52:18 UTC
> Probably, the upstream owner should be contacted and persuaded not to pull in other repositories in his Makefile.  Thanks Sam.
Actually the makefile can just be patched by the ebuild in order to remove the repositories from the Makefile, and then specific commits or tagged commits of those repositories could be added to the Portage SRC_URI as tar.gz.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-29 04:01:52 UTC
(In reply to benoit.dufour from comment #5)
> > Probably, the upstream owner should be contacted and persuaded not to pull in other repositories in his Makefile.  Thanks Sam.
> Actually the makefile can just be patched by the ebuild in order to remove
> the repositories from the Makefile, and then specific commits or tagged
> commits of those repositories could be added to the Portage SRC_URI as
> tar.gz.

Well, yeah. There's a lot of different options in theory, but what John said is still right. They should be persuaded to not do that.
Comment 7 Miroslav Šulc gentoo-dev 2024-07-06 14:17:45 UTC
i just tried to bump it but there are some issues, so giving up:

>>> Emerging (1 of 1) media-gfx/wings-2.3::gentoo
 * wings-2.3.tar.bz2 BLAKE2B SHA512 size ;-) ...                                                                                                                                                                                                                                                                                                                    [ ok ]
>>> Unpacking source...
>>> Unpacking wings-2.3.tar.bz2 to /var/tmp/portage/media-gfx/wings-2.3/work
>>> Source unpacked in /var/tmp/portage/media-gfx/wings-2.3/work
>>> Preparing source in /var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3 ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3 ...
make -j33 vsn.mk 
WINGS_VSN = 2.3
make: 'vsn.mk' is up to date.
make -j33 -C intl_tools opt ERL_LIBS=/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3 
make: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/intl_tools'
make TYPE=opt common
make[1]: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/intl_tools'
erlc  +debug_info +debug_info -o. tools.erl
escript gen_char_hrl
make[1]: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/intl_tools'
make: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/intl_tools'
make -j33 -C e3d opt ERL_LIBS=/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3 
make: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/e3d'
make TYPE=opt common
make[1]: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/e3d'
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_image.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_mesh.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_file.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_obj.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_tds.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_transform.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_mat.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_util.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_vec.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_q.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_bv.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_bvh.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_kd3.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d__tri_quad.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d__meshclean.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d__bmp.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d__dds.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d__tga.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d__png.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d__tif.erl
erlc +nowarn_match_float_zero +debug_info -o../ebin e3d_bzw.erl
make[1]: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/e3d'
make: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/e3d'
make -j33 -C src opt ERL_LIBS=/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3 
make: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/src'
make TYPE=opt common
make[1]: Entering directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/src'
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_lang.erl
sed -e 's;%WINGS_MODS%;libigl, user_default, wings, wings_align, wings_body, wings_bool, wings_camera, wings_cl, wings_cc, wings_collapse, wings_color, wings_console, wings_deform, wings_develop, wings_dialog, wings_dissolve, wings_dl, wings_drag, wings_draw, wings_draw_setup, wings_edge, wings_edge_cmd, wings_edge_loop, wings_export, wings_extrude_edge, wings_extrude_face, wings_face, wings_face_cmd, wings_facemat, wings_file, wings_ff_ndo, wings_ff_wings, wings_frame, wings_geom_win, wings_gl, wings_glfont, wings_glu_tess, wings_help, wings_hotkey, wings_info, wings_image, wings_image_viewer, wings_import, wings_io, wings_io_wx, wings_job, wings_light, wings_magnet, wings_material, wings_menu, wings_menu_util, wings_move, wings_msg, wings_obj, wings_outliner, wings_palette, wings_palette_imports, wings_pb, wings_pick, wings_pick_nif, wings_plugin, wings_pref, wings_pref_dlg, wings_proxy, wings_render, wings_rotate, wings_s, wings_sel, wings_sel_conv, wings_sel_cmd, wings_scale, wings_shaders, wings_shapes, wings_start, wings_status, wings_subdiv, wings_sup, wings_theme, wings_toolbar, wings_tesselation, wings_text, wings_tweak, wings_tweak_win, wings_u, wings_undo, wings_util, wings_va, wings_vbo, wings_vec, wings_vertex, wings_vertex_cmd, wings_view, wings_view_win, wings_we, wings_we_build, wings_we_util, wings_wm, wpa, ww_color_ctrl, ww_color_slider, jsone, jsone_decode, jsone_encode,wings_lang;' wings.app.src > ../ebin/wings.app.tmp
sed -e 's;%VSN%;2.3;' ../ebin/wings.app.tmp > ../ebin/wings.app
rm ../ebin/wings.app.tmp
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin libigl.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin user_default.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_align.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_body.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_bool.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_camera.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_cl.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_cc.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_collapse.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_color.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_console.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_deform.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_develop.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_dialog.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_dissolve.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_dl.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_drag.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_draw.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_draw_setup.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_edge.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_edge_cmd.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_edge_loop.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_export.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_extrude_edge.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_extrude_face.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_face.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_face_cmd.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_facemat.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_file.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_ff_ndo.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_ff_wings.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_frame.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_geom_win.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_gl.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_glfont.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_glu_tess.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_help.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_hotkey.erl
erlc +nowarn_match_float_zero -I ../.. -I../_deps +debug_info -pa ../intl_tools -o../ebin wings_info.erl
wings_draw.erl:120:50: syntax error before: ')'
%  120| 			proxy_data=wings_proxy:invalidate(Proxy, maybe),
%     | 			                                              ^

wings_draw.erl:111:8: function prepare_fun_2/3 undefined
%  111| 		_ -> prepare_fun_2(D, We, Wes)
%     | 		     ^

wings_draw.erl:113:11: function prepare_fun_2/3 undefined
%  113| 	false -> prepare_fun_2(D, We, Wes)
%     | 	         ^

make[1]: *** [Makefile:177: ../ebin/wings_draw.beam] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/src'
make: *** [Makefile:157: opt] Error 2
make: Leaving directory '/var/tmp/portage/media-gfx/wings-2.3/work/wings-2.3/src'
Comment 8 benoit.dufour 2024-07-06 15:20:02 UTC
I checked the code on the GitHub repo and as you can see, for the version 2.3, 
there's no such function prepare_fun_2/3 at lines 111 and 113 of the wings_draw.erl file.
https://github.com/dgud/wings/blob/v2.3/src/wings_draw.erl
Comment 9 benoit.dufour 2024-07-06 15:33:32 UTC
Actually the issue might be that the functions called prepare_fun_2 are defined after they're called?
Comment 10 Miroslav Šulc gentoo-dev 2024-07-06 20:05:12 UTC
(In reply to benoit.dufour from comment #9)
> Actually the issue might be that the functions called prepare_fun_2 are
> defined after they're called?

i guess this might indicate it:

# grep prepare_fun_2 * -r
src/wings_draw.erl:		_ -> prepare_fun_2(D, We, Wes)
src/wings_draw.erl:	false -> prepare_fun_2(D, We, Wes)
src/wings_draw.erl:prepare_fun_2(#dlo{proxy=IsUsed, proxy_data=Proxy,ns=Ns}=D, We, Wes) ->